Skip to content

fix failing CIL unit tests and Gadgetron/ISMRMRD HDF5 linking error#989

Open
paskino wants to merge 3 commits intoSyneRBI:masterfrom
paskino:fix-sirf-cil-unittests
Open

fix failing CIL unit tests and Gadgetron/ISMRMRD HDF5 linking error#989
paskino wants to merge 3 commits intoSyneRBI:masterfrom
paskino:fix-sirf-cil-unittests

Conversation

@paskino
Copy link
Copy Markdown
Contributor

@paskino paskino commented Mar 30, 2026

Changes in this pull request

Testing performed

Related issues

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • The code builds and runs on my machine
  • CHANGES.md has been updated with any functionality change

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF-SuperBuild (the Work) under the terms and conditions of the Apache-2.0 License.

@paskino
Copy link
Copy Markdown
Contributor Author

paskino commented Apr 1, 2026

The residual error in the DEVEL_BUILD is TORCH_TEST_PYTHON

https://github.com/SyneRBI/SIRF-SuperBuild/actions/runs/23851867425/job/69533945161?pr=989#step:14:1066

@KrisThielemans
Copy link
Copy Markdown
Member

It's strange that we don't get any output that says what the failure. we just have

CoverageWarning: Module sirf.torch was never imported. (module-not-imported); 

but that could be irrelevant, as the coverage stuff is broken since a few years.

On the other hand, this is the DEVEL_BUILD=OFF build (with g++11), while all others are fine. So, I wonder if we shouldn't be updating the SIRF_TAG.

@paskino
Copy link
Copy Markdown
Contributor Author

paskino commented Apr 2, 2026

No, that's the DEVEL_BUILD=ON

So currently

DEVEL_BUILD SIRF_TAG Note
OFF 11a6a50fc13bf52439d0c1ec15ebacfbadada8c5 29/1/26, before #1305
ON master after #1305

This means that only the DEVEL_BUILD=ON has the code merged from SyneRBI/SIRF#1305 and runs the relative unit tests, which fail.

It also means that indeed we need to change the SIRF_TAG to nearly master, or whatever commit we want to tag as v3.10.0.

@KrisThielemans
Copy link
Copy Markdown
Member

That's what I meant... Good luck!

@paskino paskino requested a review from casperdcl April 2, 2026 10:08
@paskino paskino added this to the v3.10.0 milestone Apr 2, 2026
@paskino paskino changed the title update CIL branch for testing fix failing CIL unit tests and Gadgetron/ISMRMRD HDF5 linking error Apr 2, 2026
Comment thread version_config.cmake Outdated
Comment thread version_config.cmake Outdated
Comment thread CHANGES.md Outdated
Comment thread CHANGES.md Outdated
@paskino paskino requested a review from casperdcl April 13, 2026 08:32
Copy link
Copy Markdown
Member

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll tackle #992 separately

wjp and others added 2 commits April 13, 2026 14:55
This fixes libhdf5 not being found when the conda version of hdf5 is
picked up by cmake. This would occur when other packages (such as
Gadgetron) link against libismrmrd but not against libhdf5 directly.
@casperdcl casperdcl force-pushed the fix-sirf-cil-unittests branch from 9598983 to 1cbe1ce Compare April 13, 2026 14:00
@casperdcl casperdcl force-pushed the fix-sirf-cil-unittests branch from 1cbe1ce to d28d89c Compare April 13, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: docker tests fail because Gadgetron is not running Fix failing CIL unittests

4 participants