fix failing CIL unit tests and Gadgetron/ISMRMRD HDF5 linking error#989
Open
paskino wants to merge 3 commits intoSyneRBI:masterfrom
Open
fix failing CIL unit tests and Gadgetron/ISMRMRD HDF5 linking error#989paskino wants to merge 3 commits intoSyneRBI:masterfrom
paskino wants to merge 3 commits intoSyneRBI:masterfrom
Conversation
Contributor
Author
|
The residual error in the |
Member
|
It's strange that we don't get any output that says what the failure. we just have but that could be irrelevant, as the coverage stuff is broken since a few years. On the other hand, this is the |
Contributor
Author
|
No, that's the So currently
This means that only the It also means that indeed we need to change the |
Member
|
That's what I meant... Good luck! |
casperdcl
reviewed
Apr 8, 2026
This fixes libhdf5 not being found when the conda version of hdf5 is picked up by cmake. This would occur when other packages (such as Gadgetron) link against libismrmrd but not against libhdf5 directly.
9598983 to
1cbe1ce
Compare
1cbe1ce to
d28d89c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Testing performed
Related issues
Checklist before requesting a review
Contribution Notes
Please read and adhere to the contribution guidelines.
Please tick the following: