Skip to content

Visbol section#987

Merged
cjmyers merged 6 commits intomainfrom
visbol-section
Mar 10, 2026
Merged

Visbol section#987
cjmyers merged 6 commits intomainfrom
visbol-section

Conversation

@zane-perry
Copy link
Contributor

@zane-perry zane-perry commented Mar 6, 2026

Closes #932

@zane-perry
Copy link
Contributor Author

Closes #932

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new “Visualization” viewing section and wires it into the side panel/page rendering flow for ComponentDefinition and ModuleDefinition pages.

Changes:

  • Insert “Visualization” into the section order for ComponentDefinition/ModuleDefinition in the side panel.
  • Add a new Visualization section that fetches visualization HTML and renders it in an iframe.
  • Update plugin/section imports and route “Visualization” page rendering through GenericContent.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
frontend/components/Viewing/SidePanel.js Prepends “Visualization” into the section order for relevant types.
frontend/components/Viewing/Sections/Visualization.js New visualization section: fetches visualization content and renders via iframe/srcDoc with resize/navigation handling.
frontend/components/Viewing/Sections/Plugin.js Fixes import paths and refactors HTML parser options placement.
frontend/components/Viewing/PageJSON/Rendering/GenericContent.js Updates Plugin import path and adds rendering branch for “Visualization”.
Comments suppressed due to low confidence (1)

frontend/components/Viewing/Sections/Plugin.js:236

  • options is defined at module scope but references properties (e.g., properties.plugin.name), which is only defined inside the Plugin component. This will throw a ReferenceError at runtime. Move options inside Plugin, or make it a factory that takes the needed values (e.g., pluginName) and returns the options object so it doesn’t rely on out-of-scope variables.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@cjmyers cjmyers merged commit 5a8f8b4 into main Mar 10, 2026
5 checks passed
@cjmyers cjmyers deleted the visbol-section branch March 10, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add VisBOL to SynBioHub2

3 participants