Add customer address books in order creation view | Add webpack by BartoszWojdalowicz · Pull Request #184 · Sylius/AdminOrderCreationPlugin

BartoszWojdalowicz · 2022-03-09T15:19:56Z

PR include behat tests.

Now created `Order` passed to email template to be able to render breakdown / user can see what he pays for

When dealing with virtual products or ( when only one shipping method is enabled and channel skipping_shipping_step_allowed )

Feature/address book

…Plugin

…rderCreationPlugin

Loocos · 2023-04-12T15:34:44Z

It could be great to merge this feature

diimpp · 2023-07-05T11:04:30Z

src/Resources/assets/admin/js/index.js

@@ -0,0 +1,8 @@
+import 'semantic-ui-css/components/dropdown';


--- src/Resources/assets/admin/js/index.js +++ src/Resources/private/admin/js/app.js

I'm not sure if it's part of new bundle notation, that allows this Resource/assets path, but it should be either Resources/private or /assets in the root if plugin's symfony version allows it

AFAIR it doesn't change anything as the paths are configured in the webpack.config.js. We can go with Resource/private (as we do in Sylius) and change it to the /assets once the plugin structure updated.

diimpp · 2023-07-05T11:06:18Z

public/build/sylius/orderCreation/shop/manifest.json

@@ -0,0 +1,4 @@
+{


Built assets shouldn't be included in git

public/build shouldn't exists in plugin unless it's a test app

jakubtobiasz

Rebase is needed
/public and /src/Resources/public should be removed
Including assets should be done with using template events
The installation guide (at least) should be updated, due to added webpack

jakubtobiasz · 2023-07-05T11:07:18Z

composer.json

+        "symfony/web-profiler-bundle": "^4.4 || ^5.4",
+        "symfony/webpack-encore-bundle": "^1.12",
+        "symfony/web-server-bundle": "^4.4 || ^5.4"


It should be ^5.4 || ^6.0

jakubtobiasz · 2023-07-06T05:27:54Z

features/creating_order/creating_order_with_address_from_address_book.feature

+    Scenario: Creating an order with both addresses from address books
+        When I create a new order for "jon.snow@the-wall.com" and channel "United States"
+        And I add "Stark Coat" to this order
+        And I see the address book shipping address select
+        And I see the address book billing address select
+        And I select first address in shipping address book with name "Jon Snow"
+        And I select first address in billing address book with name "Ned Stark"
+        And I select "Free" shipping method
+        And I select "Cash on Delivery" payment method
+        And I place and confirm this order
+        Then I should be notified that order has been successfully created
+        And this order shipping address should be "Jon Snow", "Frost Alley", "90210", "Ankh-Morpork", "United States"
+        And this order billing address should be "Ned Stark", "Banana Street", "90232", "New York", "United States"
+        And there should be one not paid nor shipped order with channel "United States" for "jon.snow@the-wall.com" in the registry


Suggested change

Scenario: Creating an order with both addresses from address books

When I create a new order for "jon.snow@the-wall.com" and channel "United States"

And I add "Stark Coat" to this order

And I see the address book shipping address select

And I see the address book billing address select

And I select first address in shipping address book with name "Jon Snow"

And I select first address in billing address book with name "Ned Stark"

And I select "Free" shipping method

And I select "Cash on Delivery" payment method

And I place and confirm this order

Then I should be notified that order has been successfully created

And this order shipping address should be "Jon Snow", "Frost Alley", "90210", "Ankh-Morpork", "United States"

And this order billing address should be "Ned Stark", "Banana Street", "90232", "New York", "United States"

And there should be one not paid nor shipped order with channel "United States" for "jon.snow@the-wall.com" in the registry

Scenario: Creating an order with both addresses from address books

When I create a new order for "jon.snow@the-wall.com" and channel "United States"

And I add "Stark Coat" to this order

And I select first address in shipping address book with name "Jon Snow"

And I select first address in billing address book with name "Ned Stark"

And I select "Free" shipping method

And I select "Cash on Delivery" payment method

And I place and confirm this order

Then I should be notified that order has been successfully created

And this order shipping address should be "Jon Snow", "Frost Alley", "90210", "Ankh-Morpork", "United States"

And this order billing address should be "Ned Stark", "Banana Street", "90232", "New York", "United States"

And there should be one not paid nor shipped order with channel "United States" for "jon.snow@the-wall.com" in the registry

If we don't see the address book select field, we can't click it. So, in my opinion, these two steps seem redundant. Same below.

jakubtobiasz · 2023-07-06T05:28:27Z

features/creating_order/creating_order_with_different_billing_address.feature

+        And I should not see the address book shipping address select
+        And I should not see the address book billing address select


Not needed as well. If there's some kind of "wait" we should move it to the specify step.

jakubtobiasz · 2023-07-06T05:30:55Z

src/Resources/assets/admin/js/index.js

@@ -0,0 +1,8 @@
+import 'semantic-ui-css/components/dropdown';


AFAIR it doesn't change anything as the paths are configured in the webpack.config.js. We can go with Resource/private (as we do in Sylius) and change it to the /assets once the plugin structure updated.

jakubtobiasz · 2023-07-06T05:36:00Z

tests/Application/templates/bundles/SyliusAdminBundle/_scripts.html.twig

+{{ encore_entry_script_tags('admin-entry', null, 'admin') }}
+{{ encore_entry_script_tags('sylius-orderCreation-admin', null, 'orderCreation_admin') }}


It should be done with using template events:

sylius.admin.layout.stylesheets

sylius.admin.layout.javascripts

sylius.shop.layout.stylesheets

sylius.shop.layout.javascripts

In such case, we don't require additional steps while installing the plugin. It applies to all 4 modified files.

BartoszWojdalowicz and others added 22 commits January 18, 2022 10:48

add address book to create order form, include js and css files

611286d

Add webpack encore to plugin

309852e

Add built assets, change plugin name

c2d7ec8

edit templates

1633e6e

add behat tests and modify existing

56d4561

Improved: OrderPaymentLinkSender

1896935

Now created `Order` passed to email template to be able to render breakdown / user can see what he pays for

Shouldn't have payment limit on order

d0d34de

Remove useless Migrations step from README.md

cd3fa75

[Maintenance] Drop support for PHP 7.4

8396442

[Maintenance] Bump up support for Symfony 5 to 5.4 version

5ee743e

[Maintenance] Bump up node version in workflow

a929f1e

[Maintenance] Drop support for Sylius 1.9 + add for Sylius 1.11

7796e5f

Replace Zend PriorityQueue with Laminas PriorityQueue

f0300f6

[Maintenance] Add notes to UPGRADE file for 0.13.0

8a516a8

Fix state machine exception on order creation

ab9353c

When dealing with virtual products or ( when only one shipping method is enabled and channel skipping_shipping_step_allowed )

added phpspec tests

7b232c3

Remove PHPUnit cache file

8ae8979

Generate changelog for v0.13.0

6bb2396

Merge branch 'master' into feature/address-book

aa83615

Merge pull request #1 from BartoszWojdalowicz/feature/address-book

bf152d5

Feature/address book

Merge branch 'master' of https://github.com/Sylius/AdminOrderCreation…

5e7d64f

…Plugin

Merge branch 'master' of https://github.com/BartoszWojdalowicz/AdminO…

79e1b42

…rderCreationPlugin

BartoszWojdalowicz requested a review from a team as a code owner March 9, 2022 15:19

BartoszWojdalowicz mentioned this pull request Mar 10, 2022

Display address book for shipping and billing address #133

Open

diimpp reviewed Jul 5, 2023

View reviewed changes

jakubtobiasz reviewed Jul 6, 2023

View reviewed changes

Loocos mentioned this pull request Jul 19, 2023

Add customer address books in order creation view | Add webpack #198

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add customer address books in order creation view | Add webpack #184

Add customer address books in order creation view | Add webpack #184
BartoszWojdalowicz wants to merge 22 commits intoSylius:mainfrom
BartoszWojdalowicz:master

BartoszWojdalowicz commented Mar 9, 2022

Uh oh!

Loocos commented Apr 12, 2023

Uh oh!

diimpp Jul 5, 2023

Uh oh!

jakubtobiasz Jul 6, 2023

Uh oh!

diimpp Jul 5, 2023

Uh oh!

jakubtobiasz left a comment •

edited

Loading

Uh oh!

jakubtobiasz Jul 5, 2023

Uh oh!

jakubtobiasz Jul 6, 2023

Uh oh!

jakubtobiasz Jul 6, 2023

Uh oh!

jakubtobiasz Jul 6, 2023

Uh oh!

jakubtobiasz Jul 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

		@@ -0,0 +1,8 @@
		import 'semantic-ui-css/components/dropdown';

		And I should not see the address book shipping address select
		And I should not see the address book billing address select

		{{ encore_entry_script_tags('admin-entry', null, 'admin') }}
		{{ encore_entry_script_tags('sylius-orderCreation-admin', null, 'orderCreation_admin') }}

Uh oh!

Conversation

BartoszWojdalowicz commented Mar 9, 2022

Uh oh!

Loocos commented Apr 12, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jakubtobiasz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jakubtobiasz left a comment •

edited

Loading