Skip to content

Register race condition fix#505

Open
omarzl wants to merge 5 commits intoSwinject:masterfrom
omarzl:fix/register-race-condition
Open

Register race condition fix#505
omarzl wants to merge 5 commits intoSwinject:masterfrom
omarzl:fix/register-race-condition

Conversation

@omarzl
Copy link
Copy Markdown

@omarzl omarzl commented Dec 7, 2021

This pr looks ugly but it is not.
It adds thread safety to the register to solve a race condition.

  • I renamed SynchronizedResolver to SynchronizedContainer
  • I created the protocols _Register and Register and I moved _register and register functions from Container to them.
  • This allows me to be able to conform Register protocol in SynchronizedContainer and make it use the same NSLock object to make register calls thread safe.
  • I modified Sources/SynchronizedContainer.Arguments.erb and ran script/gencode, there is where most of the changes come from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant