Escape dynamic scan result text in UI rendering#8
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the embedded UI results rendering to prevent HTML interpretation/injection when displaying scan/clean outputs (e.g., file paths and rename directives), ensuring user-controlled strings are shown literally.
Changes:
- Added an
escapeHtml(value)helper to escape HTML special characters before rendering dynamic content. - Updated
setResults(data)to escaperename.from,rename.to, and removalfileentries before assigninginnerHTML. - Added a manual UI regression-check section to the README.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
main.ts |
Escapes user-controlled scan results before injecting markup into the results list. |
README.md |
Documents a manual regression check for literal rendering of special characters in results. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
escapeHtml(value)helper inside the embedded UI script to escape&,<,>,", and'before rendering.setResults(data)to callescapeHtmlfor all dynamic values shown in result rows (rename.from,rename.to, and removalfileentries) before assigninginnerHTML.README.mdinstructing how to verify literal rendering for filenames containing<and>.Testing
deno task test(viadeno test -A), which failed in this environment due to an external JSR package metadata fetch error for@std/assert@1.0.19and not because of local code changes.README.md.Codex Task