Skip to content

Feature/network command#13

Merged
sidsun1 merged 6 commits into
mainfrom
feature/network
Sep 2, 2025
Merged

Feature/network command#13
sidsun1 merged 6 commits into
mainfrom
feature/network

Conversation

@JPtheOne
Copy link
Copy Markdown
Contributor

This PR adds the new network command allowing selective diagnostics (ping, traceroute, curl, DNS, sockets, iperf3). It also updates the Dockerfile to install the required networking tools.

Closes #5

@sidsun1 sidsun1 self-requested a review August 29, 2025 05:34
Copy link
Copy Markdown
Contributor

@sidsun1 sidsun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, probably ready to merge, LGTM! Great implementation of the various arguments and commands. I'd like to just ask a couple of small fixes, and in either this PR or a separate PR, I'd request that you can maybe lay out the contents in a more interpretable way (highlighting the most relevant and useful fields for SREs).

  1. Great use of straightforward commands like ping, traceroute, etc. Do the fallbacks like mtr -r, etc. provide more useful insights,. or are they simply a replacement? When packaging our application dependencies, these Linux system commands should be readily available so both wouldn't be needed if the latter is the case.

  2. I noticed some options haven't been implemented yet. Would it be possible to complete this prior to merging the PR?

  3. In this PR or later, I'd recommend adding tests (refer to main branch) just so we can cover the various cmds and ensure they work. I've tested multiple of these myself but certain cases like say network -uhd exit after cURL. Should these options be falsy values and run in the first place as they require an associated url?

sidsun1 and others added 4 commits August 28, 2025 22:51
…dd SRE-friendly output (ping summary, curl brief, condensed traceroute/mtr, sockets), and clarify traceroute→mtr fallback.

Remove iperf3, add tests, and ensure required tools (ping/traceroute/mtr/curl/dig/ss) are packaged.
Copy link
Copy Markdown
Contributor

@sidsun1 sidsun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sidsun1 sidsun1 merged commit a1f63ee into main Sep 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add Network Tooling

2 participants