Feature/network command#13
Conversation
…iperf3 selectively with simple flags, similar to the existing monitor command.
sidsun1
left a comment
There was a problem hiding this comment.
Overall, probably ready to merge, LGTM! Great implementation of the various arguments and commands. I'd like to just ask a couple of small fixes, and in either this PR or a separate PR, I'd request that you can maybe lay out the contents in a more interpretable way (highlighting the most relevant and useful fields for SREs).
-
Great use of straightforward commands like ping, traceroute, etc. Do the fallbacks like mtr -r, etc. provide more useful insights,. or are they simply a replacement? When packaging our application dependencies, these Linux system commands should be readily available so both wouldn't be needed if the latter is the case.
-
I noticed some options haven't been implemented yet. Would it be possible to complete this prior to merging the PR?
-
In this PR or later, I'd recommend adding tests (refer to main branch) just so we can cover the various cmds and ensure they work. I've tested multiple of these myself but certain cases like say
network -uhdexit after cURL. Should these options be falsy values and run in the first place as they require an associated url?
…dd SRE-friendly output (ping summary, curl brief, condensed traceroute/mtr, sockets), and clarify traceroute→mtr fallback. Remove iperf3, add tests, and ensure required tools (ping/traceroute/mtr/curl/dig/ss) are packaged.
…nto feature/network
This PR adds the new network command allowing selective diagnostics (ping, traceroute, curl, DNS, sockets, iperf3). It also updates the Dockerfile to install the required networking tools.
Closes #5