Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@
"@types/node": "^20.10.0",
"@typescript-eslint/eslint-plugin": "^6.13.0",
"@typescript-eslint/parser": "^6.13.0",
"@vitest/coverage-v8": "^1.0.0",
"@vitest/coverage-v8": "^4.1.0",
"eslint": "^8.54.0",
"eslint-config-prettier": "^9.0.0",
"husky": "^8.0.3",
"lint-staged": "^16.4.0",
"prettier": "^3.1.0",
"typescript": "^5.3.2",
"vitest": "^1.0.0"
"vitest": "^4.1.0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Vitest 4.x drops Node 18 support but project engines field still declares >=18.0.0

Vitest 4.1.0 requires node: ^20.0.0 || ^22.0.0 || >=24.0.0 (visible in the lockfile at pnpm-lock.yaml), but package.json:47 declares "node": ">=18.0.0" in the engines field. Users or CI environments running Node.js 18.x (which is still an LTS version) will be unable to run tests, as vitest will refuse to start or crash. Either the engines field should be updated to >=20.0.0 to match the new minimum requirement, or vitest should be kept at a version compatible with Node 18.

Prompt for agents
Vitest 4.1.0 requires Node.js ^20.0.0 || ^22.0.0 || >=24.0.0, but the project's engines field in package.json (line 47) still declares node >= 18.0.0. This creates an inconsistency where users on Node 18 (still an LTS version) can install the project but cannot run tests.

Two possible fixes:
1. Update the engines field in package.json to match vitest's requirement: change "node": ">=18.0.0" to "node": ">=20.0.0". Also update CONTRIBUTING.md which documents Node.js >= 18.0.0 as the prerequisite.
2. Alternatively, keep vitest at a version that supports Node 18 (e.g., vitest 2.x or 3.x) if Node 18 support is still needed.

Also check CI workflow files (in .github/) for any Node 18 matrix entries that would need updating.
Open in Devin Review (Beta)

Was this helpful? React with 👍 or 👎 to provide feedback.

Debug

Playground

},
"engines": {
"node": ">=18.0.0",
Expand Down
Loading
Loading