[Refactor:Plagiarism] Link Boost statically#99
Open
williamjallen wants to merge 4 commits intomainfrom
Open
Conversation
Member
|
Could you add stats of how much the docker image size changed and how the the executable size changed? |
williamjallen
changed the title
shailpatels
reviewed
May 7, 2023
Member
Author
|
Closing this in favor of compiling all C++ code in the container, and then squashing intermediate layers to keep the container size small. A PR with those changes will be forthcoming. |
Member
Author
|
Opening this back up for review since it doesn't harm anything and adds a basic CMake config. I plan to build on this in a future PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Boost is currently linked dynamically, which causes Lichen to be fragile when changes are made to the underlying operating system.
What is the new behavior?
Links Boost statically, using CMake instead of a manual compilation line. This change significantly reduced the size of the Lichen Docker image, at the expense of a much larger executable.
Image size:
Executable size: