Skip to content

Add Cancel/Dismiss pseudo-skill#378

Open
tylxr59 wants to merge 4 commits intoStypox:masterfrom
tylxr59:add-dismiss-command
Open

Add Cancel/Dismiss pseudo-skill#378
tylxr59 wants to merge 4 commits intoStypox:masterfrom
tylxr59:add-dismiss-command

Conversation

@tylxr59
Copy link
Contributor

@tylxr59 tylxr59 commented Dec 15, 2025

Adds a cancel/dismiss pseudo-skill so users can dismiss the assistant after intentional or unintentional activation.

Also sets up a hidden skills section so it doesn't show up in Settings or on the What I Can Do card.

Resolves #334

@tylxr59
Copy link
Contributor Author

tylxr59 commented Dec 15, 2025

Merged all of my PRs into one branch on my fork - https://github.com/tylxr59/dicio-android/tree/tylxrs-build
Compiled APK for testing - https://github.com/tylxr59/dicio-android/raw/refs/heads/tylxrs-build/app-debug.apk

@pablowako
Copy link

Great work, I'm looking forward to this merge!

Consider adding "no" as an option, since you have "no thanks" and a good candidate reply to "did you mean to call X?" is simply "no".

Also, why hide the skill? I'd like to know, when I'm new to the app, that this is possible, as well as the words that trigger it. Maybe add it to some note or otherwise document it inside the app?

@pablowako
Copy link

I don't mean to come across as rude. These are legitimate questions.

@tylxr59
Copy link
Contributor Author

tylxr59 commented Jan 24, 2026

Sorry for the delayed response!

I can definitely add just plain "no" as an option, kind of surprised I missed it tbh.

And the purpose of hiding it as a skill is that it does not function as a normal skill. Personally, I would prefer to have this in a more general README or documentation and not clutter up the skills page, as I have added a few in my PRs. Perhaps @Stypox or @Inhishonor would have some input on this?

@tylxr59 tylxr59 closed this Jan 24, 2026
@tylxr59 tylxr59 reopened this Jan 24, 2026
@tylxr59
Copy link
Contributor Author

tylxr59 commented Jan 24, 2026

Whoops, was tired and hit the wrong button 😪

@Stypox
Copy link
Owner

Stypox commented Feb 23, 2026

I initially tended to agree that the cancel skill should remain hidden, as in @tylxr59's implementation, but after thinking about it a bit more, I think it's worth adding it as a normal skill. This will allow users to disable it, in case it interferes with other skills, and also users will learn that it is possible to say "Cancel" from the "What can I do" menu.

Copy link
Owner

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice addition, code mostly looks good to me!

Comment on lines +1 to +2
exit:
- cancel|exit|stop|quit|dismiss|(never mind)|nevermind|(forget it)|(no thanks?)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth adding all of these to util_yes_no.yml, under sentence ID "no"? And then you would build CancelSkill only using the "no" sentence (this requires adding a function to StandardRecognizerData that keeps only some sentences, as explained in other PRs too).

tylxr59 and others added 2 commits February 25, 2026 19:33
Co-authored-by: Stypox <stypox@pm.me>
Co-authored-by: Stypox <stypox@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "nevermind" fallback command

3 participants