Conversation
|
Merged all of my PRs into one branch on my fork - https://github.com/tylxr59/dicio-android/tree/tylxrs-build |
|
Great work, I'm looking forward to this merge! Consider adding "no" as an option, since you have "no thanks" and a good candidate reply to "did you mean to call X?" is simply "no". Also, why hide the skill? I'd like to know, when I'm new to the app, that this is possible, as well as the words that trigger it. Maybe add it to some note or otherwise document it inside the app? |
|
I don't mean to come across as rude. These are legitimate questions. |
|
Sorry for the delayed response! I can definitely add just plain "no" as an option, kind of surprised I missed it tbh. And the purpose of hiding it as a skill is that it does not function as a normal skill. Personally, I would prefer to have this in a more general README or documentation and not clutter up the skills page, as I have added a few in my PRs. Perhaps @Stypox or @Inhishonor would have some input on this? |
|
Whoops, was tired and hit the wrong button 😪 |
|
I initially tended to agree that the cancel skill should remain hidden, as in @tylxr59's implementation, but after thinking about it a bit more, I think it's worth adding it as a normal skill. This will allow users to disable it, in case it interferes with other skills, and also users will learn that it is possible to say "Cancel" from the "What can I do" menu. |
Stypox
left a comment
There was a problem hiding this comment.
Thanks for this nice addition, code mostly looks good to me!
| exit: | ||
| - cancel|exit|stop|quit|dismiss|(never mind)|nevermind|(forget it)|(no thanks?) |
There was a problem hiding this comment.
Maybe it's worth adding all of these to util_yes_no.yml, under sentence ID "no"? And then you would build CancelSkill only using the "no" sentence (this requires adding a function to StandardRecognizerData that keeps only some sentences, as explained in other PRs too).
Co-authored-by: Stypox <stypox@pm.me>
Co-authored-by: Stypox <stypox@pm.me>
Adds a cancel/dismiss pseudo-skill so users can dismiss the assistant after intentional or unintentional activation.
Also sets up a hidden skills section so it doesn't show up in Settings or on the What I Can Do card.
Resolves #334