Skip to content

feat: add login page#43

Closed
yiningsoong wants to merge 8 commits intomainfrom
feat/38-email-otp-ui
Closed

feat: add login page#43
yiningsoong wants to merge 8 commits intomainfrom
feat/38-email-otp-ui

Conversation

@yiningsoong
Copy link
Copy Markdown
Contributor

@yiningsoong yiningsoong commented Jan 20, 2026 •
edited
Loading

closes #38

🚀 Summary

Contains the login flow page
(only ui portion, no backend/integration)

✏️ Changes

  • Add react-hook-form
  • Add login page consisting of Email form and OTP form (supports responsive)
  • Add TW (extended from flowDS) to consolidate stylings

⌛ Pending

  • To check with @rezailmi on a couple of things
  1. Should error message be under input or under the button?
Screenshot 2026-02-09 at 5 09 51 PM
  1. Should 'back' navigation from OTP section return to Homepage or Email section?
  2. Should there be wrapping in mobile view for?
Screenshot 2026-02-09 at 5 07 11 PM

@yiningsoong yiningsoong marked this pull request as draft January 20, 2026 15:56
@yiningsoong yiningsoong force-pushed the feat/38-email-otp-ui branch 2 times, most recently from 6e3323f to 3e0cb1f Compare January 22, 2026 12:18
@yiningsoong yiningsoong force-pushed the feat/38-email-otp-ui branch 5 times, most recently from 47ce7be to 69cc452 Compare February 9, 2026 06:03
@yiningsoong yiningsoong marked this pull request as ready for review February 9, 2026 06:03
@yiningsoong yiningsoong force-pushed the feat/38-email-otp-ui branch 2 times, most recently from 053fac9 to 1263f28 Compare February 9, 2026 09:22
YimingIsCOLD
YimingIsCOLD reviewed Feb 9, 2026
View reviewed changes
Comment thread web/components/Button.tsx Outdated
Comment thread web/App.tsx Outdated
Comment thread web/containers/LoginView.tsx Outdated
Comment thread web/containers/LoginView.tsx Outdated
@yiningsoong yiningsoong force-pushed the feat/38-email-otp-ui branch 5 times, most recently from 4419ff6 to 4e25cb2 Compare February 13, 2026 09:55
@yiningsoong yiningsoong self-assigned this Feb 13, 2026
@YimingIsCOLD
Copy link
Copy Markdown
Contributor

YimingIsCOLD commented Apr 14, 2026

Closing this PR because the branch is too far behind main, and opening a fresh PR will be easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YimingIsCOLD YimingIsCOLD YimingIsCOLD left review comments

Assignees

@yiningsoong yiningsoong

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create email OTP page

2 participants

@yiningsoong @YimingIsCOLD