Skip to content

Fix pending transaction check to cover both initiator and partner #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: fix/prod
Choose a base branch
from
Draft

Fix pending transaction check to cover both initiator and partner #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e10ea1d
Initial plan
Copilot Mar 10, 2026
6a99251
Expand pending transaction check to include partnerId in any role
Copilot Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions app/api/sessions/[id]/transactions/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,17 @@ export async function POST(req: Request, { params }: { params: { id: string } })
return NextResponse.json({ error: 'One or both players have already traded' }, { status: 400 });
}

// Check for pending transactions
// Check for pending transactions involving either player in any role
const pending = await sql`
SELECT id FROM transactions
WHERE round_id = ${round.id} AND status = 'pending' AND (initiator_id = ${initiatorId} OR partner_id = ${initiatorId})
WHERE round_id = ${round.id} AND status = 'pending'
AND (
initiator_id = ${initiatorId} OR partner_id = ${initiatorId}
OR initiator_id = ${partnerId} OR partner_id = ${partnerId}
)
`;
if (pending.length > 0) {
return NextResponse.json({ error: 'You already have a pending transaction' }, { status: 400 });
return NextResponse.json({ error: 'One or both players already have a pending transaction' }, { status: 400 });
}

const txs = await sql`
Expand Down