Validate shocks POST inputs and default priceShift server-side#5
Merged
Validate shocks POST inputs and default priceShift server-side#5
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ks POST route Co-authored-by: ghostleek <44336310+ghostleek@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on sessions API and UI fixes
Validate shocks POST inputs and default priceShift server-side
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
priceShiftwas omitted by the client, it passedundefineddirectly into the SQL insert, causing aNOT NULLconstraint violation and a 500.typeanddescriptionwere also unvalidated, silently inserting nulls or garbage.Changes
typeanddescriptionmust be non-empty strings; returns400with a descriptive message if either failspriceShiftdefault — falls back to10server-side when the client omits it or sends a non-finite value (NaN,Infinity)🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.