Open
Conversation
Collaborator
Transurgeon
commented
Feb 16, 2026
Transurgeon
commented
- Add parameter, scalar_mult, vector_mult bindings for updatable params
- Add register_params and update_params problem bindings
- Update constant.h to use unified new_parameter with PARAM_FIXED
- Update const_scalar_mult.h and const_vector_mult.h for new parameter API
- Unify left_matmul and left_param_matmul into single binding that accepts (param_or_none, child, csr_data, csr_indices, csr_indptr, m, n)
- Update SparseDiffEngine submodule to parameter-support branch
- Register all new methods in bindings.c
- Unify make_left_matmul and make_left_param_matmul into single binding - Accept (param_or_none, child, data, indices, indptr, m, n) - Delete left_param_matmul.h (merged into left_matmul.h) - Update SparseDiffEngine submodule (simplified new_left_matmul API) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Transurgeon
force-pushed
the
parameter-support
branch
from
90bf2c1 to
4ce7315
Compare
- left_matmul.h: replace col-major conversion with direct CSR data pass to new_parameter(nnz, 1, PARAM_FIXED, ...) - Update SparseDiffEngine submodule (CSR data order for params) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update py_make_right_matmul signature to (param_or_none, child, data, indices, indptr, m, n) matching left_matmul. When param_or_none is None, a PARAM_FIXED node is created internally; otherwise the passed parameter capsule is used for updatable sparse parameters. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.