fix: battery power sign, negative zero, and net energy dip consistency#186
Merged
cayossarian merged 6 commits intomainfrom Mar 11, 2026
Merged
fix: battery power sign, negative zero, and net energy dip consistency#186cayossarian merged 6 commits intomainfrom
cayossarian merged 6 commits intomainfrom
Conversation
The panel reports battery power from its own perspective (positive = charging), but HA energy cards expect positive = discharging. Negate the value to align with HA conventions, consistent with how PV power is already handled. Fixes #184
Power sensors that negate values (PV circuits, battery, PV power) could produce IEEE 754 -0.0 when idle, causing HA to display -0W instead of 0W. All negation sites now normalize zero with `or 0.0`. Fixes #185
When energy dip compensation is enabled, consumed and produced sensors apply an offset to the raw value but net energy was computed from raw snapshot values, causing a visible mismatch. Consumed/produced sensors now register on the coordinator so net energy can read their offsets directly and adjust its value to stay consistent.
Reformat ternary lambda in circuit power sensor to match CI ruff version's preferred style.
Pre-commit was pinned to ruff 0.11.13 while CI used 0.15.1 from pyproject.toml, causing formatting disagreements on ternary lambdas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
0Wnot-0W