Skip to content

Several more C++ migrations in admin, Discord & HTTP systems#403

Merged
Vauff merged 4 commits intoSource2ZE:devfrom
notkoen:cutlvector-patch
Mar 2, 2026
Merged

Several more C++ migrations in admin, Discord & HTTP systems#403
Vauff merged 4 commits intoSource2ZE:devfrom
notkoen:cutlvector-patch

Conversation

@notkoen
Copy link
Contributor

@notkoen notkoen commented Nov 7, 2025

This pull request changes CUtlVector usage in adminsystem.cpp and discord.cpp to std::vector.

Copy link
Contributor

@Vauff Vauff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the spirit of these std changes, you should also fully convert this stuff to C++ memory style alongside this. With the vector elements as smart pointers, and the CDiscordBot string fields as std::string.

@notkoen notkoen closed this Feb 6, 2026
@notkoen notkoen reopened this Feb 6, 2026
Vauff added 2 commits March 1, 2026 22:47
std::string params allow for more flexibility, since both C & C++ strings can be passed in
@Vauff Vauff changed the base branch from main to dev March 2, 2026 04:10
@Vauff Vauff changed the title Change CUtlVector usage in AdminSystem and Discord to std::vector Several more C++ migrations in admin, Discord & HTTP systems Mar 2, 2026
@Vauff Vauff merged commit e535beb into Source2ZE:dev Mar 2, 2026
3 checks passed
@notkoen notkoen deleted the cutlvector-patch branch March 2, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants