CLI-356 Fetch analysis properties for SCA analysis#244
CLI-356 Fetch analysis properties for SCA analysis#244georgii-borovinskikh-sonarsource wants to merge 2 commits intomasterfrom
Conversation
9dd70e8 to
32bc027
Compare
d3b25d4 to
4ab3259
Compare
SummaryThis PR implements CLI-356: fetching SCA analysis properties from SonarQube project settings. What changed:
Why it matters: What reviewers should knowWhere to focus:
Key decisions:
What to watch:
|
4ab3259 to
97d1e57
Compare
d1099a5 to
307e6a4
Compare
damien-urruty-sonarsource
left a comment
There was a problem hiding this comment.
LGTM, one suggestion to improve performance
| const componentExists = await client.checkComponent(options.project); | ||
| if (!componentExists) { | ||
| throw new CommandFailedError(`No project: ${options.project}`); | ||
| } |
There was a problem hiding this comment.
Could we avoid this extra round-trip? Do we receive a 404 when we try to get settings for a non-existing project in the call below, and could we rely on that?
|



No description provided.