SLE-1443 Migrate to Java 21 for the backend#1020
SLE-1443 Migrate to Java 21 for the backend#1020damien-urruty-sonarsource merged 4 commits intomasterfrom
Conversation
SummaryThis PR is a comprehensive infrastructure migration and project restructuring for SonarLint Eclipse. It upgrades the version to 12.0.0 and establishes the project's CI/CD pipeline with GitHub Actions workflows, adds testing infrastructure for multiple Eclipse/Java versions (including Java 21 support), and refactors the build system. The changes include 1,088 files with ~66K insertions, establishing root-level Maven configuration, GitHub Actions workflows (build, release, PR management, security scanning), build automation scripts, target platform definitions for testing, and a complete integration test suite with test project templates. What reviewers should knowStart here:
Key architectural decisions:
Non-obvious elements:
|
...e.core/src/org/sonarlint/eclipse/core/internal/preferences/SonarLintGlobalConfiguration.java
Show resolved
Hide resolved
...nt.eclipse.ui/src/org/sonarlint/eclipse/ui/internal/preferences/SonarLintPreferencePage.java
Outdated
Show resolved
Hide resolved
|
Overall, I give this a 💯 |
d12c147 to
09d554d
Compare
kirill-knize-sonarsource
left a comment
There was a problem hiding this comment.
LGTM. Couple nits on error logging.
...nt.eclipse.core/src/org/sonarlint/eclipse/core/internal/backend/SonarLintBackendService.java
Outdated
Show resolved
Hide resolved
...nt.eclipse.core/src/org/sonarlint/eclipse/core/internal/backend/SonarLintBackendService.java
Outdated
Show resolved
Hide resolved
09d554d to
1213183
Compare
1213183 to
612ab74
Compare
There was a problem hiding this comment.
LGTM! ✅
Solid PR. The Java 21 migration is clean — preference key rename with a well-tested migration path, version detection via the release file, and startup/preference-page warnings all hang together correctly. The timeout fix in SonarLintBackendService (join() → get(1, TimeUnit.MINUTES)) is the headline reliability improvement and is handled correctly including interrupt restoration. No bugs found beyond the previously acknowledged self-managed JRE validation gap.
893ba25 to
6f7b7fa
Compare
6f7b7fa to
dfc36da
Compare
|




No description provided.