Skip to content

RUST-141 Disable pin/rollback updates for SonarSource GitHub Actions#232

Merged
saberduck merged 2 commits intomasterfrom
fix/disable-sonar-actions-pin-updates
May 4, 2026
Merged

RUST-141 Disable pin/rollback updates for SonarSource GitHub Actions#232
saberduck merged 2 commits intomasterfrom
fix/disable-sonar-actions-pin-updates

Conversation

@saberduck
Copy link
Copy Markdown
Contributor

  • Adds a `packageRule` to disable `pin` and `rollback` update types for `SonarSource/*` GitHub Actions
  • Prevents Renovate from recreating PRs that replace `@v3` tags with exact versions
  • Pattern from SonarSource/renovate-config#122

@saberduck saberduck requested a review from a team as a code owner April 30, 2026 15:12
@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha Bot commented Apr 30, 2026

Summary

This PR adds a packageRule to Renovate that disables pin and rollback updates for SonarSource GitHub Actions (matching both SonarSource/* and sonarsource/*). This prevents Renovate from automatically replacing semantic version tags like @v3 with exact pinned versions, which would otherwise create unnecessary PRs. The change also updates the extends configuration to use the languages-team branch of the shared renovate-config instead of the local reference.

The rationale is that keeping SonarSource actions on stable major version tags (e.g., @v3) is preferable to pinned exact versions, allowing automatic receipt of patch and minor updates while maintaining flexibility.

What reviewers should know

Key file to review: renovate.json — the new packageRule (lines 102–117) is added alongside existing rules that group and manage GitHub Actions updates.

What reviewers should focus on:

  • The new packageRule matches both SonarSource/* and sonarsource/* to handle case variations
  • The enabled: false disables only pin and rollback types; other update types (patch, minor, major) remain enabled
  • The extends config change from local> to github>SonarSource/renovate-config:languages-team is a separate alignment; verify this branch exists in the shared renovate-config repo if unfamiliar

Non-obvious detail: This rule sits after an earlier rule that groups "all Sonar GitHub Actions," so ordering matters — the more specific rule (disabling pin/rollback) takes precedence for SonarSource packages.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Disable pin/rollback updates for SonarSource GitHub Actions RUST-141 Disable pin/rollback updates for SonarSource GitHub Actions Apr 30, 2026
@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod Bot commented Apr 30, 2026

RUST-141

sonar-review-alpha[bot]

This comment was marked as resolved.

@saberduck saberduck force-pushed the fix/disable-sonar-actions-pin-updates branch from e7b2e8c to 1fda287 Compare April 30, 2026 20:26
sonar-review-alpha[bot]

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I don't think we have the config on sonar-skunk
Saw the PR on FPS and sonar-skunk

Comment thread renovate.json Outdated
Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single question before approving: does the languages-team preset in SonarSource/renovate-config already include the pin/rollback disable rule added in the previous commit? If so, the local packageRules entry at lines 102–116 is redundant and can be removed — no harm having it twice, but it will silently drift if the centralized rule ever changes scope.

🗣️ Give feedback

Comment thread renovate.json
@saberduck saberduck enabled auto-merge (squash) May 4, 2026 14:59
@sonarqube-next
Copy link
Copy Markdown

sonarqube-next Bot commented May 4, 2026

Quality Gate passed Quality Gate passed for 'sonar-rust'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@saberduck saberduck merged commit 522c238 into master May 4, 2026
12 checks passed
@saberduck saberduck deleted the fix/disable-sonar-actions-pin-updates branch May 4, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants