Skip to content

Fix duplicate PSU creation when dmidecode reports identical PSUs #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shbatm wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −0
Open

Fix duplicate PSU creation when dmidecode reports identical PSUs #401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions netbox_agent/power.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ def __init__(self, server=None):

def get_power_supply(self):
power_supply = []
seen_psus = set()

for psu in dmidecode.get_by_type(self.server.dmi, PSU_DMI_TYPE):
if "Present" not in psu["Status"] or psu["Status"] == "Not Present":
continue
Expand All @@ -36,6 +38,20 @@ def get_power_supply(self):
continue
if sn == "":
sn = "N/A"

# Create a unique key based on all PSU attributes to detect duplicates
psu_key = (sn, desc, max_power)

# Skip duplicate PSUs (same serial, description, and max power)
if psu_key in seen_psus:
logging.debug(
"Skipping duplicate PSU: name={}, description={}, max_power={}W".format(
sn, desc, max_power
)
)
continue

seen_psus.add(psu_key)
power_supply.append(
{
"name": sn,
Expand Down