Skip to content

Cleanup sharing dict in RemoteDistDataset#519

Merged
kmontemayor2-sc merged 6 commits intomainfrom
kmonte/cleanup-rdi
Mar 3, 2026
Merged

Cleanup sharing dict in RemoteDistDataset#519
kmontemayor2-sc merged 6 commits intomainfrom
kmonte/cleanup-rdi

Conversation

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator

@kmontemayor2-sc kmontemayor2-sc commented Feb 27, 2026

Scope of work done

We should cleanup the dict, for two reasons:

  1. For the ABLP case, it'd be possible to pollute the dict if there are negative labels for one supervision edge type, and none for another but we'd still return negative labels as their key is in the dict.
  2. Save memory if we can del those tensors later this dataset shouldn't be holding onto them.

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

kmontemayor2-sc commented Feb 27, 2026

/all_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 02:27:33UTC : 🔄 Python Unit Test started.

@ 03:45:43UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 02:27:33UTC : 🔄 Integration Test started.

@ 04:05:04UTC : ❌ Workflow failed.
Please check the logs for more details.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 02:27:33UTC : 🔄 E2E Test started.

@ 03:47:46UTC : ❌ Workflow failed.
Please check the logs for more details.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 02:27:34UTC : 🔄 Scala Unit Test started.

@ 02:35:27UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 02:27:34UTC : 🔄 Lint Test started.

@ 02:34:55UTC : ✅ Workflow completed successfully.

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

kmontemayor2-sc commented Feb 27, 2026

/all_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 04:12:57UTC : 🔄 Lint Test started.

@ 04:19:58UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 04:12:57UTC : 🔄 Integration Test started.

@ 05:35:07UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 04:12:57UTC : 🔄 Scala Unit Test started.

@ 04:21:33UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 04:13:00UTC : 🔄 Python Unit Test started.

@ 05:20:53UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 04:13:01UTC : 🔄 E2E Test started.

@ 05:31:39UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

kmontemayor2-sc commented Feb 27, 2026

/all_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 18:47:27UTC : 🔄 Integration Test started.

@ 20:02:50UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 18:47:27UTC : 🔄 E2E Test started.

@ 20:05:39UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 18:47:27UTC : 🔄 Lint Test started.

@ 18:54:17UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 18:47:32UTC : 🔄 Scala Unit Test started.

@ 18:55:46UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 18:47:33UTC : 🔄 Python Unit Test started.

@ 18:54:46UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

kmontemayor2-sc commented Feb 27, 2026

/all_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 19:49:20UTC : 🔄 Scala Unit Test started.

@ 19:59:13UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 19:49:20UTC : 🔄 Integration Test started.

@ 21:09:49UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 19:49:21UTC : 🔄 Lint Test started.

@ 19:59:37UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 19:49:23UTC : 🔄 Python Unit Test started.

@ 21:00:40UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026 •
edited
Loading

GiGL Automation

@ 19:49:25UTC : 🔄 E2E Test started.

@ 21:16:52UTC : ❌ Workflow failed.
Please check the logs for more details.

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator Author

kmontemayor2-sc commented Mar 2, 2026

/all_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 2, 2026 •
edited
Loading

GiGL Automation

@ 17:32:59UTC : 🔄 Python Unit Test started.

@ 18:41:28UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 2, 2026 •
edited
Loading

GiGL Automation

@ 17:33:00UTC : 🔄 Integration Test started.

@ 19:05:13UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 2, 2026 •
edited
Loading

GiGL Automation

@ 17:33:02UTC : 🔄 E2E Test started.

@ 19:01:49UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 2, 2026 •
edited
Loading

GiGL Automation

@ 17:33:02UTC : 🔄 Scala Unit Test started.

@ 17:42:09UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 2, 2026 •
edited
Loading

GiGL Automation

@ 17:33:02UTC : 🔄 Lint Test started.

@ 17:40:02UTC : ✅ Workflow completed successfully.

svij-sc
svij-sc approved these changes Mar 3, 2026
View reviewed changes
Comment thread examples/link_prediction/graph_store/heterogeneous_inference.py
Comment thread examples/link_prediction/graph_store/homogeneous_inference.py
@kmontemayor2-sc kmontemayor2-sc marked this pull request as ready for review March 3, 2026 18:10
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main with commit 04c0afa Mar 3, 2026
6 checks passed
@kmontemayor2-sc kmontemayor2-sc deleted the kmonte/cleanup-rdi branch March 3, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svij-sc svij-sc svij-sc approved these changes

@yliu2-sc yliu2-sc yliu2-sc approved these changes

@nshah-sc nshah-sc Awaiting requested review from nshah-sc nshah-sc is a code owner

@mkolodner-sc mkolodner-sc Awaiting requested review from mkolodner-sc mkolodner-sc is a code owner

@xgao4-sc xgao4-sc Awaiting requested review from xgao4-sc xgao4-sc is a code owner

@zfan3-sc zfan3-sc Awaiting requested review from zfan3-sc zfan3-sc is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kmontemayor2-sc @svij-sc @yliu2-sc @kmonte