chore(test): live marker + CI guard for LLM/API discipline (pass 2 L3)#32
Merged
Conversation
Layer 3 of test-strategy pass 2: - pyproject.toml: register the `live` pytest marker (joins the existing `e2e` marker); extend addopts to deselect both (`-ra -m 'not e2e and not live'`). attune-gui makes no LLM calls directly (heavy lifting is in attune-author and attune-rag); the marker is reserved so future tests have a consistent home. - tests.yml: add a CI guard step (in the python matrix job) that fails fast if ANTHROPIC_API_KEY is set in the default test environment. Regression alarm, not routine — GitHub Actions secrets aren't exposed unless explicitly named in env:, so this only fires if someone wires a secret into the wrong job. The frontend Vitest job doesn't need it. - sidecar/tests/README.md: replace the inline LLM-mocking section with a pointer to testing-conventions.md in the attune workspace umbrella. Verified locally: 492 passing + 3 deselected + 1 xfailed; coverage gate (`fail_under = 77`) holds at 82.89% branch coverage. (3 cowork tests fail locally due to cwd-dependent fixtures that pass in CI — not caused by these changes.) Spec: /Users/patrickroebuck/attune/specs/test-strategy-pass-2/ Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layer 3 of test-strategy pass 2. Three small changes — same shape as L1 (attune-help #8) and L2 (attune-rag #16).
pyproject.toml— register thelivemarker (joins existinge2efrom pass 1); extendaddoptsto deselect both (-ra -m 'not e2e and not live').github/workflows/tests.yml— add CI guard step in the python matrix job assertingANTHROPIC_API_KEYis unset for default suite. Frontend Vitest job doesn't need it.sidecar/tests/README.md— swap inline LLM-mocking section for a pointer totesting-conventions.mdin the attune workspace umbrella.Prerequisite
Depends on Smart-AI-Memory/attune#4 (workspace
testing-conventions.md) for the README pointer to resolve.Test plan
pytest --covlocally — 492 passing, 82.89% branch coverage; gate (fail_under = 77) holdsruff checkclean🤖 Generated with Claude Code