Open
Conversation
feat: 增加扇渲染
feat: 设置扇子 HUD 位置
feat: CUSTOM_ITEM_RENDERER 事件，取代 ISinoItem
qyl27
reviewed
Mar 29, 2025
Member
There was a problem hiding this comment.
配置文件API的话，我希望引入Configurate，它会让我们的生活更美好它的API很完善
Contributor
Author
There was a problem hiding this comment.
主要是，懒得去写neoforge和Fabric两套了，暂时先用这个吧。这个只是个简单的客户端配置读写实现，到时候有了 Configurate 替换下就行。
| background.getTextureWidth(), background.getTextureHeight(), | ||
| TEXTURE.getWidth(), TEXTURE.getHeight()); | ||
| Component titlePosition = Component.translatable(SBRConstants.Translation.GUI_FAN_SETTING_HUD_POSITION); | ||
| Component titleHide = Component.translatable(isHudShow() ? SBRConstants.Translation.GUI_SETTING_HIDE : SBRConstants.Translation.GUI_SETTING_SHOW); |
Contributor
Author
There was a problem hiding this comment.
是的，一开始我不是把扇子渲染在游戏界面上了嘛。那个方案没有删只是在编辑界面加了个隐藏按钮
qyl27
requested changes
Mar 31, 2025
| background.getTextureWidth(), background.getTextureHeight(), | ||
| TEXTURE.getWidth(), TEXTURE.getHeight()); | ||
| Component titlePosition = Component.translatable(SBRConstants.Translation.GUI_FAN_SETTING_HUD_POSITION); | ||
| Component titleHide = Component.translatable(isHudShow() ? SBRConstants.Translation.GUI_SETTING_HIDE : SBRConstants.Translation.GUI_SETTING_SHOW); |
Contributor
Author
|
已删除hud |
Contributor
Author
|
有几个用于实现 hud 的组件，是否需要删除
|
Member
|
嗯感觉事件先放着吧，那个config不是说迁移到configurate吗 |
qyl27
requested changes
Apr 1, 2025
Member
There was a problem hiding this comment.
这里对initClient应该放在ClientModInitializer里
Contributor
Author
等换了再说，到时候直接删了包就行 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.