Skip to content

Add building and container recipes#15

Closed
feegeer wants to merge 2 commits intoSimulation-Software-Engineering:mainfrom
feegeer:main
Closed

Add building and container recipes#15
feegeer wants to merge 2 commits intoSimulation-Software-Engineering:mainfrom
feegeer:main

Conversation

@feegeer
Copy link
Copy Markdown

@feegeer feegeer commented Nov 23, 2025

I was not sure how

From your pull request, it should be possible to create an executable container. After running the container, it should be possible to cd into cmake-exercise and then run the build_and_run.sh script.

was meant. I assumed it means that

  • there should be a Dockerfile that can be built
  • when running and interactively entering the container, there is a directory cmake-exercise, where build_and_run.sh can be run

Copy link
Copy Markdown

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good here and works, thanks!

Comment thread CMakeLists.txt

find_package(yaml-cpp REQUIRED)

add_library(fem fem/fem.cpp)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to turn every directory into a stand-alone library, but ok.

@MakisH
Copy link
Copy Markdown

MakisH commented Apr 10, 2026

Everything looks good here and works, thanks!

@MakisH MakisH closed this Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants