[MS-1343] MFID lighting conditions assessment hints for OCR#1619
Draft
[MS-1343] MFID lighting conditions assessment hints for OCR#1619
Conversation
…ther features. Function names updated accordingly.
Vertical margins of adjacent views adjusted to reclaim some space.
…s for glare detection
alex-vt
commented
Mar 17, 2026
| @RunWith(AndroidJUnit4::class) | ||
| internal class GetLightingConditionsAssessmentUseCaseTest { | ||
| private lateinit var useCase: GetLightingConditionsAssessmentUseCase | ||
|
|
Contributor
Author
BurningAXE
reviewed
Mar 17, 2026
| if (::lightingConditionsAssessmentConfig.isInitialized && lightingConditionsAssessmentConfig.isEnabled) { | ||
| lightingConditionsAssessmentFlow.value = getLightingConditionsAssessment( | ||
| bitmap = cropped, | ||
| lightingConditionsAssessmentConfig = lightingConditionsAssessmentConfig, |
Contributor
There was a problem hiding this comment.
Does it make sense to move the config initialization in the use case? This will clean up the VM and will allow easier reuse for QR scanning. For the case when lightning assessment is disabled, the use case can simply return a null and have the flow be optional - if null, no hint to display.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




JIRA ticket
Will be released in: 2026.2.0
Notable changes
When capturing an ID card when MFID (External credential) is enabled, a hint is shown for the user under the camera viewfinder target area, when the lighting conditions are deemed difficult for OCR of text on a card.
Hints for abnormal lighting conditions are:
Hints are displayed not only after the Scan button is pressed, but also before - in the preview. This guides the user to better lighting early, and aims for a smoother UX.
In these examples:
This feature is experimental. It needs to be enabled in the Custom Configs for the project with MFID.
The simplest custom config:
Full reference:
There's no user-controlled on/off switch for this feature, because it is an advisory hint only, not affecting user flows.
Code changes
Testing guidance
Additional work checklist