MS-1382 Explicitly throw exception on unsuccessful event up/down sync responses

[luhmirin-s]

JIRA ticket
Will be released in: 2025.2.1

Root cause analysis (for bugfixes only)

First known affected version: 2024.1.5

• When retrofit interface returns Response<T> type, then it will never throw during call execution.

Notable changes

• If event up and down sync requests return any non 2xx response, we now manually throw HttpException.
• Sync tasks already expect that data source calls can throw (there are even unit tests for such cases).
• Other cases of Response<T> are also already covered correctly.

Testing guidance

• Sync should work as expected.
• There isn't really a way to reliably reproduce the issue by hand, so we will have to rely on unit tests.

Additional work checklist

• Effect on other features and security has been considered
• Design document marked as "In development" (if applicable)
• External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
• Test cases in Testiny are up to date (or ticket created)
• Other teams notified about the changes (if applicable)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud