MS-1382 Explicitly throw exception on unsuccessful event up/down sync responses

[luhmirin-s]

JIRA ticket
Will be released in: 2025.4.2

Root cause analysis (for bugfixes only)

First known affected version: 2024.1.0

• When retrofit interface returns Response<T> type, then it will never throw during call execution.

Notable changes

• If event up and down sync requests return any non 2xx response, we now manually throw HttpException.
• Sync tasks already expect that data source calls can throw (there are even unit tests for such cases).
• Other cases of Response<T> are also already covered correctly.

Testing guidance

• Sync should work as expected.
• There isn't really a way to reliably reproduce the issue by hand, so we will have to rely on unit tests.

Additional work checklist

• Effect on other features and security has been considered
• Design document marked as "In development" (if applicable)
• External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
• Test cases in Testiny are up to date (or ticket created)
• Other teams notified about the changes (if applicable)

[Copilot]

Pull request overview

This PR fixes a sync reliability gap where Retrofit methods returning Response<T> don’t throw on non-2xx HTTP statuses, by explicitly throwing when event up-sync / down-sync requests return unsuccessful responses.

Changes:

• Throw retrofit2.HttpException when down-sync download (downloadEvents) returns a non-2xx Response.
• Throw retrofit2.HttpException when up-sync upload (uploadEvents) returns a non-2xx Response.
• Add unit tests asserting exceptions are thrown for non-2xx responses for both download and upload paths.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
infra/event-sync/src/main/java/com/simprints/infra/eventsync/event/remote/EventRemoteDataSource.kt	Adds explicit non-2xx handling by throwing HttpException for download/upload responses.
infra/event-sync/src/test/java/com/simprints/infra/eventsync/event/remote/EventRemoteDataSourceTest.kt	Adds tests validating exceptions are thrown when the Retrofit interface returns non-2xx Response objects.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud