feat: add volume control to slack#102
Open
maciejBart99 wants to merge 1 commit intoSikora00:developfrom
Open
Conversation
maciejBart99
force-pushed
the
feature/volume_control
branch
2 times, most recently
from
491e038 to
bc5c7ff
Compare
maciejBart99
force-pushed
the
feature/volume_control
branch
from
bc5c7ff to
a24b6a5
Compare
Owner
|
I'm not sure if we should store exactly volume value in the db. Because web client will have to send every change of the volume. Maybe just emit by websocket commands "louder"... Without specific value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.