Conversation
…it versions, updated schema to 12.5, and adjusted deprecation handling
…pitalization style.
…removed redundant serialization methods, and standardized JSON output structure 🫃
…plementation phases, and architectural changes.
…e mapping and XML handling (I guess good idea 😜)
…place Point constants with PointType enum 🫃
…orting in Codecov 🤠
…ew actions, and enable advanced navigation features 🤩
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the 2.x draft MR that turns parts of the “Road to 2.x” plan and long-standing issues into actual code instead of wishful thinking. [github](#67)
Implemented in this draft
Implemented a new, more explicit approach to statistics objects.
stats->toArray()” towards proper typed objectsAdded support and/or internal plumbing for more advanced statistics and bounds, in line with Statistics - get Bounds of the GPX Routes #28 (Statistics – get Bounds of the GPX Routes).
Refined the elevation smoothing internals, taking into account the ongoing discussion in How does elevation smoothing best work? #55 and cumulativeElevationGain and cumulativeElevationLoss not correct when missing parts of track with gps problem? #59.
APPLY_ELEVATION_SMOOTHING,ELEVATION_SMOOTHING_THRESHOLD, andELEVATION_SMOOTHING_SPIKES_THRESHOLDmore predictably.Started implementing the 2.x cleanup around Removal of Summarizable and toArray #69 (Removal of Summarizable and toArray) and Middlewares #68 (Middlewares).
toArray()usage in models in favor of explicit, typed data structures and a clearer serialization story. githubBreaking changes
stats->toArray()) will need updating to work with the new typed objects.Feedback welcome on
If you find something weird, confusing, or hilarious in a bad way, please comment. It’s still called “2.x draft,” which means I can rename, move, and rethink things without having to blame “backwards compatibility” yet.