Skip to content

Don't delete RBI files for missing constants in LSP addon mode #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KaanOzkan wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Don't delete RBI files for missing constants in LSP addon mode #2526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lib/tapioca/commands/abstract_dsl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,11 +175,16 @@ def constantize(constant_names, ignore_missing: false)
unless unprocessable_constants.empty? || ignore_missing
unprocessable_constants.each do |name, _|
say("Error: Cannot find constant '#{name}'", :red)
filename = dsl_rbi_filename(name)
remove_file(filename) if File.file?(filename)

unless @lsp_addon
filename = dsl_rbi_filename(name)
remove_file(filename) if File.file?(filename)
end
end

raise Tapioca::Error, ""
unless @lsp_addon
raise Tapioca::Error, ""
end
end

processable_constants
Expand Down
2 changes: 1 addition & 1 deletion lib/tapioca/commands/dsl_generate.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def execute
rbi_files_to_purge = generate_dsl_rbi_files(@outpath, quiet: @quiet && !@verbose)
say("")

purge_stale_dsl_rbi_files(rbi_files_to_purge)
purge_stale_dsl_rbi_files(rbi_files_to_purge) unless @lsp_addon
say("Done", :green)

if @auto_strictness && !@lsp_addon
Expand Down
Loading