Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,22 @@ jobs:
ruby:
- '3.2'
- '3.3'
- '3.4'
Comment thread
ntn marked this conversation as resolved.
- '4.0'
gemfile:
- Gemfile
- gemfiles/rails-7.0.gemfile
- gemfiles/rails-7.1.gemfile
- gemfiles/rails-7.2.gemfile
- gemfiles/rails-8.0.gemfile
- gemfiles/rails-edge.gemfile
exclude:
- ruby: '3.2'
gemfile: gemfiles/rails-edge.gemfile

name: Ruby ${{ matrix.ruby }} ${{ matrix.gemfile }}
steps:
- uses: actions/checkout@50fbc622fc4ef5163becd7fab6573eac35f8462e # v1.2.0
- uses: actions/checkout@v4
- name: Set up Ruby ${{ matrix.ruby }}
uses: ruby/setup-ruby@e34163cd15f4bb403dcd72d98e295997e6a55798 # v1.238.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why these were pinned down. 🤔

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe supply chain security? Unpinning means we get auto-updates with new Ruby versions and bug fixes so I think we should make this change but I don't have the context in this repo to know for sure

uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
Expand Down
6 changes: 0 additions & 6 deletions gemfiles/rails-7.0.gemfile

This file was deleted.

6 changes: 0 additions & 6 deletions gemfiles/rails-7.1.gemfile

This file was deleted.

6 changes: 6 additions & 0 deletions gemfiles/rails-7.2.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
source 'https://rubygems.org'

gemspec path: '..'

gem 'activesupport', '~> 7.2'
gem 'activerecord', '~> 7.2'
6 changes: 6 additions & 0 deletions gemfiles/rails-8.0.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
source 'https://rubygems.org'

gemspec path: '..'

gem 'activesupport', '~> 8.0'
gem 'activerecord', '~> 8.0'
2 changes: 1 addition & 1 deletion lib/measured/version.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# frozen_string_literal: true
module Measured
VERSION = "3.2.1"
VERSION = "3.3.0"
end
4 changes: 2 additions & 2 deletions measured.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
spec.homepage = "https://github.com/Shopify/measured"
spec.license = "MIT"

spec.required_ruby_version = ">= 3.0.0"
spec.required_ruby_version = ">= 3.2.0"

# Prevent pushing this gem to RubyGems.org by setting 'allowed_push_host', or
# delete this section to allow pushing this gem to any host.
Expand All @@ -28,7 +28,7 @@ Gem::Specification.new do |spec|
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ["lib"]

spec.add_runtime_dependency "activesupport", ">= 5.2"
spec.add_runtime_dependency "activesupport", ">= 7.2"

spec.add_development_dependency "rake", "> 10.0"
spec.add_development_dependency "minitest", "> 5.5.1"
Expand Down
Loading