Gracefully catch unexpected html (non json) response from external services#6873
Merged
alfonso-noriega merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
alfonso-noriega
force-pushed
the
1325-error-unexpected-token-htmlh-is-not-valid-json
branch
3 times, most recently
from
50808c2 to
9d4ac4e
Compare
Contributor
Coverage report
Test suite run success3767 tests passing in 1448 suites. Report generated by 🧪jest coverage report action from 6b9e797 |
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
alfonso-noriega
requested review from
dmerand,
gonzaloriestra and
isaacroldan
alfonso-noriega
force-pushed
the
1325-error-unexpected-token-htmlh-is-not-valid-json
branch
3 times, most recently
from
e54bc82 to
956932e
Compare
gonzaloriestra
approved these changes
Feb 24, 2026
Contributor
gonzaloriestra
left a comment
gonzaloriestra
left a comment
There was a problem hiding this comment.
Makes sense, thanks!
Just a few minor suggestions.
alfonso-noriega
force-pushed
the
1325-error-unexpected-token-htmlh-is-not-valid-json
branch
from
956932e to
6b9e797
Compare
alfonso-noriega
deleted the
1325-error-unexpected-token-htmlh-is-not-valid-json
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Issue #1325
Vault error
Observe error
JSON parsing errors in HTTP responses were causing unhandled exceptions and poor error messages when external services return malformed responses or are temporarily unavailable.
WHAT is this pull request doing?
Add proper error handling for JSON parsing failures in HTTP response processing across three modules:
AbortErrorwhen identity service returns invalid JSONAll error messages inform users that the service may be temporarily unavailable and suggest retrying.
Measuring impact
How do we know this change was effective? Please choose one:
Checklist