Added alternate Api/* class generator for non-arm systems#39
Merged
elidrissidev merged 2 commits intoShipStream:mainfrom Jan 8, 2026
Merged
Added alternate Api/* class generator for non-arm systems#39elidrissidev merged 2 commits intoShipStream:mainfrom
elidrissidev merged 2 commits intoShipStream:mainfrom
Conversation
…sion of the `elidrissidev/openapi-merge:152` package to generate the `src/Api/*` classes. The included `generate.sh` script was not compatible with my AMD64 (WSL2-Ubuntu) setup. - Added `elidrissidev/openapi-merge:152` as a composer dev dependency (required by `generate-amd64.sh`). - Added `cebe/php-openapi:1.7.0` as a composer dev dependency to lock version at 1.7.0. This was required because `elidrissidev/openapi-merge` depends on "^1.7.0" which results in "1.8.0" being installed which is not compatible. - Updated the `src/Api/*` classes by running `generate-amd64.sh` which fixes all PHP 8.4 deprecated warnings for "Implicitly marking parameter <variable> as nullable is deprecated, the explicit nullable type must be used instead" being triggered by the included generated classes in the current release.
Contributor
|
Thanks for the PR, Rick! We'll try to review and merge soon. |
Collaborator
|
Hey @RickKukiela, I pushed an update to |
…w commits from upstream master in the generated api files.
Contributor
Author
|
@elidrissidev I just merged your changes in and accepted your files and re-pushed/re-opened (after it auto-closed). It appears to pass now. |
Collaborator
|
Thanks! |
elidrissidev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #38
Changes:
generate-amd64.shscript which uses the composer loaded version of theelidrissidev/openapi-merge:152package to generate thesrc/Api/*classes. The includedgenerate.shscript was not compatible with my AMD64 (WSL2-Ubuntu) setup.elidrissidev/openapi-merge:152as a composer dev dependency (required bygenerate-amd64.sh).cebe/php-openapi:1.7.0as a composer dev dependency to lock version at 1.7.0. This was required becauseelidrissidev/openapi-mergedepends on "^1.7.0" which results in "1.8.0" being installed which is not compatible.src/Api/*classes by runninggenerate-amd64.shwhich fixes all PHP 8.4 deprecated warnings for "Implicitly marking parameter as nullable is deprecated, the explicit nullable type must be used instead" being triggered by the included generated classes in the current release.