#81 CI maintenance: clean up cspell.json and Slack notification wiring

[kernelsam]

Summary

• Remove unused words from .vscode/cspell.json
• Use needs.<job>.result instead of needs.<job>.outputs.status for Slack notifications

Closes #81

---

Resolves #81

[github-actions]

🤖 Claude Code Review

Code Review

Code Quality

✅ Code follows style guide - YAML formatting is clean and consistent.

✅ No commented-out code - No commented-out code present.

✅ Meaningful variable names - N/A for CI/config changes.

✅ DRY principle - The fix actually improves this by removing the redundant job output that was mirroring a native GitHub Actions value.

✅ No defects - The core fix is correct. Using needs.pylint.result is the idiomatic GitHub Actions approach for checking a job's completion state. The previous pattern (outputs.status: ${{ job.status }}) was a workaround that is unnecessary and less reliable — job.status in outputs evaluates at job completion and is redundant when needs.<job>.result exists for exactly this purpose. This is a valid bug fix.

✅ CLAUDE.md - Contains general development guidance suitable for any developer.

---

Testing

✅ N/A - CI configuration and spell check dictionary changes do not require unit/integration tests.

---

Documentation

❌ CHANGELOG.md not updated - No CHANGELOG.md entry is included in the diff. Depending on project convention, CI maintenance changes may warrant a changelog entry.

✅ No README changes needed - Internal CI/tooling change only.

✅ Markdown/JSON formatting - .vscode/cspell.json diff appears clean. No markdown files were modified.

---

Security

✅ No hardcoded credentials - None present.

✅ No sensitive data - The removed cspell words are non-sensitive domain terms (entity names, transliterations).

✅ No license files - No .lic or AQAAAD-prefixed content.

---

Summary

This is a clean CI maintenance PR with two focused changes:

1. pylint.yaml — Replaces the indirect job.status output pattern with the native needs.pylint.result, which is the correct and more reliable approach in GitHub Actions.
2. cspell.json — Removes domain-specific terms (OFAC/sanctions-related names, transliterations) that are no longer needed, keeping the word list lean.

Minor note: Consider adding a CHANGELOG entry if the project tracks CI changes there.

Automated code review analyzing defects and coding standards

[github-actions]

Super-linter summary

Language	Validation result
CHECKOV	Pass ✅
GITHUB_ACTIONS	Pass ✅
GITHUB_ACTIONS_ZIZMOR	Pass ✅
GITLEAKS	Pass ✅
GIT_MERGE_CONFLICT_MARKERS	Pass ✅
JSCPD	Pass ✅
PRE_COMMIT	Pass ✅
SPELL_CODESPELL	Pass ✅
TRIVY	Pass ✅
YAML	Pass ✅
YAML_PRETTIER	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter