Skip to content

#83 CI maintenance: clean up cspell.json and Slack notification wiring#84

Merged
kernelsam merged 1 commit intomainfrom
83-skern
Mar 23, 2026
Merged

#83 CI maintenance: clean up cspell.json and Slack notification wiring#84
kernelsam merged 1 commit intomainfrom
83-skern

Conversation

@kernelsam
Copy link
Contributor

@kernelsam kernelsam commented Mar 23, 2026

Summary

  • Remove unused words from .vscode/cspell.json
  • Use needs.<job>.result instead of needs.<job>.outputs.status for Slack notifications

Closes #83


Resolves #83

@kernelsam kernelsam requested review from a team as code owners March 23, 2026 17:20
@kernelsam kernelsam self-assigned this Mar 23, 2026
@kernelsam kernelsam enabled auto-merge (squash) March 23, 2026 17:20
@github-actions
Copy link

🤖 Claude Code Review

Code Review

Code Quality

Style guide - Changes are minimal CI/workflow configuration only; no Python code changes to evaluate.

No commented-out code - No commented-out code introduced.

Meaningful variable names - N/A for this diff.

DRY principle - N/A for this diff.

Defects - The core fix is correct. Using needs.pylint.result (a built-in GitHub Actions job result: success, failure, cancelled, skipped) is the proper approach instead of needs.pylint.outputs.status. The previous pattern was fragile because job.status in an outputs block may not always propagate as expected. This is a valid bug fix.

CLAUDE.md - No changes to project configuration; no concerns.

Testing

Unit/integration tests - Not applicable for CI workflow changes.

Documentation

README - No documentation changes needed for CI maintenance.

CHANGELOG.md - Not updated, but given this is a CI-only maintenance fix (removing unused output, fixing Slack notification wiring), it's a judgment call. For a project that maintains a CHANGELOG, this could warrant a minor entry, but it's not critical.

Markdown/CommonMark - No markdown files changed.

Security

No hardcoded credentials - Clean.

No license files - None present.


Summary

This is a clean, focused CI maintenance PR with two logical changes:

  1. .github/workflows/pylint.yaml - Replaces the custom outputs.status pattern with the native needs.pylint.result, which is the correct GitHub Actions idiomatic approach. The outputs block on the pylint job is also removed as it's no longer needed.

  2. .vscode/cspell.json - Removes esbenp and stackoverflow from the spell-check dictionary. These appear to have been unnecessary entries (likely added as false-positive suppressions that are no longer needed).

Verdict: Approved. No issues found. The changes are correct and improve CI reliability.

Automated code review analyzing defects and coding standards

@github-actions
Copy link

Super-linter summary

Language Validation result
CHECKOV Pass ✅
GITHUB_ACTIONS Pass ✅
GITHUB_ACTIONS_ZIZMOR Pass ✅
GITLEAKS Pass ✅
GIT_MERGE_CONFLICT_MARKERS Pass ✅
JSCPD Pass ✅
PRE_COMMIT Pass ✅
SPELL_CODESPELL Pass ✅
TRIVY Pass ✅
YAML Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@kernelsam kernelsam merged commit 938cb0e into main Mar 23, 2026
27 checks passed
@kernelsam kernelsam deleted the 83-skern branch March 23, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI maintenance: clean up cspell.json and Slack notification wiring

2 participants