Skip to content

#52 CI maintenance: clean up cspell.json and Slack notification wiring#53

Merged
kernelsam merged 1 commit intomainfrom
52-skern
Mar 23, 2026
Merged

#52 CI maintenance: clean up cspell.json and Slack notification wiring#53
kernelsam merged 1 commit intomainfrom
52-skern

Conversation

@kernelsam
Copy link
Contributor

@kernelsam kernelsam commented Mar 23, 2026

Summary

  • Remove unused words from .vscode/cspell.json
  • Use needs.<job>.result instead of needs.<job>.outputs.status for Slack notifications

Closes #52


Resolves #52

@kernelsam kernelsam requested review from a team as code owners March 23, 2026 17:25
@kernelsam kernelsam self-assigned this Mar 23, 2026
@kernelsam kernelsam enabled auto-merge (squash) March 23, 2026 17:25
@github-actions
Copy link

🤖 Claude Code Review

PR Code Review

Code Quality

Style guide - Changes are minimal CI/workflow fixes, no application code style concerns.

No commented-out code - None present.

Meaningful variable names - N/A for this diff.

DRY principle - N/A for this diff.

Defects - The fix is correct. Using needs.pylint.result (a built-in GitHub Actions job result property) instead of needs.pylint.outputs.status (a custom output that required explicit wiring) is the proper approach. The old pattern was fragile — if the job was cancelled before the output was set, the condition would fail silently. needs.<job>.result is always populated by the runner.

Project CLAUDE.md - Not applicable / not present in diff.

Testing

Unit/integration tests - Not applicable; these are CI workflow changes only.

Test coverage - N/A.

Documentation

README - No changes needed for CI-only fixes.

API docs - N/A.

Inline comments - N/A.

⚠️ CHANGELOG.md - Not included in the diff. If this project maintains a CHANGELOG, this CI maintenance fix may warrant a brief entry (e.g., under a "CI" or "Maintenance" section). Low severity — many projects don't log CI-only changes.

Markdown formatting - No markdown files changed.

Security

No hardcoded credentials - None.

Input validation - N/A.

Error handling - N/A.

No sensitive data in logs - N/A.

No license files - None present.


Summary

The changes are clean and correct:

  1. pylint.yaml — Properly replaces the custom outputs.status pattern with the native needs.pylint.result. This is more reliable because result is always set by the GitHub Actions runner regardless of job outcome, whereas a custom output can be undefined if the job is cancelled mid-run.

  2. cspell.json — Removes the "esbenp" word (likely a VS Code extension author name that no longer appears in the codebase). Straightforward cleanup.

No blocking issues. The only minor item is the optional CHANGELOG entry.

Automated code review analyzing defects and coding standards

@github-actions
Copy link

Super-linter summary

Language Validation result
CHECKOV Pass ✅
GITHUB_ACTIONS Pass ✅
GITHUB_ACTIONS_ZIZMOR Pass ✅
GITLEAKS Pass ✅
GIT_MERGE_CONFLICT_MARKERS Pass ✅
JSCPD Pass ✅
PRE_COMMIT Pass ✅
SPELL_CODESPELL Pass ✅
TRIVY Pass ✅
YAML Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@kernelsam kernelsam assigned docktermj and unassigned kernelsam Mar 23, 2026
@kernelsam kernelsam merged commit dd11a55 into main Mar 23, 2026
31 checks passed
@kernelsam kernelsam deleted the 52-skern branch March 23, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI maintenance: clean up cspell.json and Slack notification wiring

2 participants