Feature/sn auth package extraimprovements#1643
Open
Conversation
…ithub.com/SenseNet/sn-client into feature/sn-auth-package-extraimprovements
…ithub.com/SenseNet/sn-client into feature/sn-auth-package-extraimprovements
* feat: add Docker containerization support - Add Dockerfile for SenseNet client application - Add docker-compose.dev.yml for development with hot reload - Add docker-compose.prod.yml for production deployment - Add .dockerignore for optimized builds - Add .env.example for environment configuration Usage: - Development: docker-compose -f docker-compose.dev.yml up -d - Production: docker-compose -f docker-compose.prod.yml up -d * feat: add Docker CI/CD workflow - Add GitHub Actions workflow for Docker image builds - Builds and pushes to DockerHub with smart tagging - Triggers on pushes to docker-containerization branch - Triggers on PRs to develop, main, and sn-auth-package-extraimprovements - Safely skips build if no Dockerfile exists - Uses branch-based and SHA-based tags for versioning * fix: Docker workflow tag format issue - Fix invalid tag format causing build failure - Use proper suffix/prefix for SHA tags - Ensure Docker tag compliance * fix: prevent duplicate workflow runs - Skip draft PRs to avoid duplicate builds - Only trigger PR builds when PR is ready for review - Maintain push-based builds for active development * remove space * refactor: remove SHA-only Docker tags - Remove standalone SHA tags to prevent DockerHub clutter - Keep clean branch names and branch+SHA tags for useful scenarios - Maintain manageable tag strategy for long-term development * docs: update Docker documentation to reflect simplified setup - Removed multi-stage Dockerfile complexity - Updated documentation to match single Dockerfile approach - Both dev and prod modes use 'yarn snapp start' - Development uses volume mounts for hot reload - Production uses built-in code without volumes - Simplified and cleaner Docker setup * fix: improve Docker setup and CI workflow - fix CI workflow: push to DockerHub only on push events, not PRs - add develop/main/feature branches to push trigger - fix docker-compose.dev.yml: remove unsupported glob volume patterns - fix docker-compose.prod.yml: use pre-built image, env_file, configurable port - fix .gitignore: add .env and .env.*.local patterns
- webpack devServer allowedHosts controlled by ALLOWED_HOSTS env var - docker-compose.dev.yml sets ALLOWED_HOSTS=all to allow nginx reverse proxy
- add yarn snapp build to Dockerfile to compile bundle at image build time - switch CMD from webpack-dev-server to 'serve' static file server - container startup reduced from minutes to seconds - reduce HEALTHCHECK start-period from 60s to 15s - docker-compose.dev.yml still overrides CMD for local hot reload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.