Open
Conversation
Contributor
|
Hey, thanks for the PR! Quick review: See some inline imports still hanging around. We still need to finalize the source spec, but when we do this will be a great addition! Are you hanging out in the sendspin channels on the Music Assistant discord? |
Author
|
Thanks for the feedback. I removed the remaining inline imports in daemon.py and moved them to module-level imports in commit 61938c8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
source@v1reference implementation tosendspin-cli.You can now run source input in two modes:
sendspin source run(source-only client)sendspin daemon --source(player + source in one process)The implementation supports line-in capture and synthetic sine input, source state reporting, source start/stop control, optional source control hooks, and reconnect behavior aligned with daemon operation.
What’s included
sendspin/source_stream.pysendspin/source_utils.pysource runcommand--source-*)--list-input-devices)source@v1support in hello when enabledsource runNotes
--source-hook-play--source-hook-pause--source-hook-next--source-hook-previous--source-hook-activate--source-hook-deactivate