Disable prefix caching for qwen3.5 & glm5 AMD benchmarks#969
Closed
functionstackx wants to merge 1 commit intomainfrom
Closed
Disable prefix caching for qwen3.5 & glm5 AMD benchmarks#969functionstackx wants to merge 1 commit intomainfrom
functionstackx wants to merge 1 commit intomainfrom
Conversation
Add --disable-radix-cache to SGLang server launch commands for: - qwen3.5_bf16_mi300x.sh - qwen3.5_bf16_mi325x.sh - qwen3.5_bf16_mi355x.sh - qwen3.5_fp8_mi300x.sh - qwen3.5_fp8_mi325x.sh - qwen3.5_fp8_mi355x.sh - glm5_fp8_mi355x.sh Closes #968 Co-authored-by: functionstackx <functionstackx@users.noreply.github.com>
Contributor
Author
|
@claude resolve the conflicts plz |
Collaborator
|
Claude finished @functionstackx's task in 3m 8s —— View job • Resolving Merge Conflicts
Changes applied to 7 files:
| |
Contributor
There was a problem hiding this comment.
LGTM
Extended reasoning...
Overview\nThis PR adds --disable-radix-cache to 7 AMD benchmark shell scripts (qwen3.5 bf16/fp8 across mi300x/mi325x/mi355x, and glm5 fp8 mi355x). The change is purely additive — one flag appended to SGLang server launch commands in benchmark-only scripts.\n\n### Security Risks\nNone. These are benchmark runner scripts with no auth, crypto, or permission logic.\n\n### Level of Scrutiny\nLow. This is a mechanical, uniform config change across benchmark scripts following the same pattern already established in other scripts (e.g., minimax PR #966, kimi PR #926). No logic changes, no new code paths.\n\n### Other Factors\nNo bugs were found. The change is consistent with prior PRs that disabled prefix caching for other models on AMD hardware. The flag placement (before the redirect) is syntactically correct in all 7 files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable prefix caching (radix cache) for qwen3.5 and glm5 AMD benchmark scripts by adding
--disable-radix-cacheto SGLang server launch commands.Files changed:
Closes #968
Generated with Claude Code