Blockmodel refactor upload add delete deltas cache#239
Open
tim-hamblin-seequent wants to merge 4 commits intoSeequentEvo:mainfrom
Open
Conversation
…block_model_to_cache, delete_block_model, and get_deltas_for_block_model as public methods, and add the deleted filter to list_all_block_models. Add corresponding unit tests and missing return type annotations.
denis-simo
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extract public upload_block_model method from _upload_data
Extract query_block_model_to_cache from query_block_model_as_table
Add delete_block_model and get_deltas_for_block_model client methods
Add deleted parameter to list_all_block_models
Add missing return type annotations to several async methods
Add tests for upload, delete, deltas, cache query, and deleted filter
Checklist