Conversation
+ Remove exec_with_connection! macro; inline the SchemaManager setup at each call site to match up()/down() + Move Postgres transaction wrapping into drop_everything itself so fresh atomicity is preserved
|
Not sure about this. I'm expecting it to tolerate |
sorry, I don't quite get the verdict. is the new behaviour in this PR good enough? note that before this change, everything is wrapped in transaction on Postgres which is a bit strange |
Fixes #3001
exec_with_connection!macro that unconditionally wrapped all Postgres operations in a transactioninto_database_executor()/SchemaManager::new()pattern at each call site (fresh, refresh, reset, uninstall), matching the approach already used byup()anddown()drop_everythinginto the function itself so atomicity is preserved