feat(cors-proxy): add redirect following and refactor callbacks#5
Open
nicomiguelino wants to merge 2 commits intomasterfrom
Open
feat(cors-proxy): add redirect following and refactor callbacks#5nicomiguelino wants to merge 2 commits intomasterfrom
nicomiguelino wants to merge 2 commits intomasterfrom
Conversation
- Add `handleRedirect` to follow 301-308 redirects recursively - Add `handleProxyResponse` to handle response headers and body piping - Set CORS headers on proxied responses - Extract inline callbacks to named functions to stay within line limits
There was a problem hiding this comment.
Pull request overview
Adds redirect-following behavior and refactors response handling in the development CORS proxy server so proxied responses include CORS headers and redirect logic is centralized.
Changes:
- Introduces
handleRedirectandhandleProxyResponseto replace inline callbacks. - Adds automatic following of HTTP redirects (301–308).
- Ensures CORS headers are set on proxied (non-redirect) responses.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Reject non-http/https redirect protocols with 502 - Resolve relative Location URLs against the current proxied URL - Only auto-follow redirects for idempotent methods (GET/HEAD) - Enforce a 10-hop redirect limit, returning 508 when exceeded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleRedirect,handleProxyResponse)