Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion node/bottube_feed_routes.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ def _parse_feed_limit(default: int = 20, maximum: int = 100) -> int:
raw_limit = request.args.get("limit")
if raw_limit in (None, ""):
return default
return max(1, min(int(raw_limit), maximum))
limit = int(raw_limit)
if limit < 0:
raise ValueError("limit must be non-negative")
return max(1, min(limit, maximum))


def _get_db_connection():
Expand Down
7 changes: 7 additions & 0 deletions tests/test_bottube_feed_routes.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,13 @@ def test_rss_feed_invalid_limit(self):
response = self.client.get("/api/feed/rss?limit=invalid")
self.assertEqual(response.status_code, 400)

def test_feed_negative_limit_rejected(self):
"""Test negative limits are rejected across feed variants."""
for path in ("/api/feed/rss", "/api/feed/atom", "/api/feed"):
with self.subTest(path=path):
response = self.client.get(f"{path}?limit=-1")
self.assertEqual(response.status_code, 400)

def test_rss_feed_excessive_limit(self):
"""Test RSS feed caps limit to 100."""
response = self.client.get("/api/feed/rss?limit=999")
Expand Down