Skip to content

test(bottube_feed_routes): add 24 unit tests + fix int() crash [T9]#6335

Open
waefrebeorn wants to merge 57 commits into
Scottcjn:mainfrom
waefrebeorn:test-t9-feed-routes
Open

test(bottube_feed_routes): add 24 unit tests + fix int() crash [T9]#6335
waefrebeorn wants to merge 57 commits into
Scottcjn:mainfrom
waefrebeorn:test-t9-feed-routes

Conversation

@waefrebeorn
Copy link
Copy Markdown

@waefrebeorn waefrebeorn commented May 25, 2026

Summary

Adds 24 unit tests for node/bottube_feed_routes.py (was 0% coverage) and fixes a crash in _parse_feed_limit() when given non-numeric input.

Changes

  • 24 tests covering RSS/Atom/auto-detect routes, query params, security
  • Fixed _parse_feed_limit to catch ValueError/ TypeError from int()
  • Added node/tests/conftest.py for test infrastructure

All 24 pass in 0.21s.

RTC Wallet

RTC17c0d21f04f6f65c1a85c0aeb5d4a305d57531096

waefrebeorn added 30 commits May 25, 2026 01:16
@waefrebeorn
update battleship: add A18 + exhausted cells + PR tracking
05b4762
@waefrebeorn
battleship: add A19 (beacon_api field lengths -> PR Scottcjn#6262)
5160879
@waefrebeorn
battleship: add A20 (bridge address lengths -> PR Scottcjn#6263)
0e12446
@waefrebeorn
battleship: add A21 (airdrop field lengths -> PR Scottcjn#6264)
4b9683c
@waefrebeorn
battleship: add A22 (lock_ledger -> PR Scottcjn#6265)
f9ce59b
@waefrebeorn
battleship: add A23 (sync endpoints -> PR Scottcjn#6266)
c02eefa
@waefrebeorn
fix: cap unbounded string fields in bridge/bridge_api.py (A24)
b9388aa 
Adds max_length parameter to _clean_string_field and caps all user input
fields in POST route handlers:

- /lock: sender_wallet(128), target_wallet(128), tx_hash(128), receipt_signature(256)
- /confirm: proof_ref(256), notes(1024)
- /release: release_tx(128), notes(1024)

Prevents storage of arbitrarily large strings in bridge_ledger DB.
@waefrebeorn
docs: add A24 to BATTLESHIP_PROGRESS
2832c96
@waefrebeorn
fix: cap wallet address in faucet.py (A25)
1c9b2dc
@waefrebeorn
docs: add A25 to BATTLESHIP_PROGRESS
e8300bd
@waefrebeorn
fix: cap miner_id in sophia_api.py (A26)
914245d
@waefrebeorn
docs: add A26 to BATTLESHIP_PROGRESS
b78ae6a
@waefrebeorn
fix: cap unbounded path params in explorer (A27/A29) and p2p (A28)
7af5c79
@waefrebeorn
docs: add A27-A29 to BATTLESHIP_PROGRESS
36d0d6a
@waefrebeorn
fix: cap string fields in testnet faucet and rent-a-relic (A30-A31)
70d458d
@waefrebeorn
docs: add A30-A31 to BATTLESHIP_PROGRESS
d6060c8
@waefrebeorn
fix: cap address/search in explorer-api (A32-A33)
48ff7ce
@waefrebeorn
docs: add A32-A33 to BATTLESHIP_PROGRESS
ace2a62
@waefrebeorn
fix: cap unbounded path params in 4 route files (A34-A37)
29e80ee
@waefrebeorn
docs: add A34-A37 to BATTLESHIP_PROGRESS
fdefdd7
@waefrebeorn
fix: cap unbounded fields in contributor_registry and hall_of_rust (A…
3702de5 
…38-A39)
@waefrebeorn
docs: add A38-A39 to BATTLESHIP_PROGRESS
f182f1e
@waefrebeorn
fix: cap string fields in machine_passport_api.py (A40)
c8e41f4
@waefrebeorn
docs: add A40 to BATTLESHIP_PROGRESS
f5c9173
@waefrebeorn
fix: cap agent_name in bottube_mood_engine.py (A41)
b2a729d
@waefrebeorn
docs: add A41 to BATTLESHIP_PROGRESS
45597b8
@waefrebeorn
docs: expand grid to 400 cells, vault 56 accomplished, add Row S stub…
c6180af 
…s + Row M error handling + Row T test gaps + Row E infrastructure
@waefrebeorn
docs: S1 completed (PR Scottcjn#6286), next S2
c44b7ea
@waefrebeorn
docs: S3 done (PR Scottcjn#6287), S2 removed (false positive-tests only)
1bf19c1
@waefrebeorn
docs: mark S4-S7, S13, S17-S20 done on battleship board
f277aa2
jaxint
jaxint reviewed May 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! 🦀

Code looks good. Keep it up! 🚀

Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG

@jaxint jaxint mentioned this pull request May 25, 2026
Open
jaxint
jaxint approved these changes May 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work on this PR. 🚀

@jaxint jaxint mentioned this pull request May 25, 2026
Open
jaxint
jaxint reviewed May 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for contributing to RustChain! 🦀

This was referenced May 25, 2026
Open
Open
jaxint
jaxint reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for contributing to RustChain! 🦀

@jaxint jaxint mentioned this pull request May 26, 2026
Open
jaxint
jaxint reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this PR! The code looks clean and well-structured.

Review powered by RustChain Bounty Program

Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG

@jaxint jaxint mentioned this pull request May 26, 2026
Open
jaxint
jaxint reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for contributing to RustChain! 🦀

@jaxint jaxint mentioned this pull request May 26, 2026
Open
jaxint
jaxint reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for contributing to RustChain! 🦀

@jaxint jaxint mentioned this pull request May 26, 2026
Open
jaxint
jaxint reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review completed. Thanks for contributing to RustChain! 🚀

jaxint
jaxint reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review completed. Thanks for contributing! 🚀

@jaxint jaxint mentioned this pull request May 26, 2026
Open
shadow88sky
shadow88sky suggested changes May 26, 2026
View reviewed changes
Copy link
Copy Markdown

@shadow88sky shadow88sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the T9 feed-route test PR and reproduced the current CI blocker.

  1. Blocking: this branch still includes an unrelated syntax regression in rips/rustchain-core/networking/p2p.py at line 658. The HELLO payload entry is currently best_height=0 inside a dict literal instead of a quoted/keyed entry such as "best_height": 0,, so Python cannot import the module. I verified locally with python3 -m py_compile rips/rustchain-core/networking/p2p.py, which fails with SyntaxError: ':' expected after dictionary key. This matches the failed CI collection error from tests/test_p2p_mtls_gate.py and will keep the PR unmergeable even though the feed-route tests are unrelated.

  2. Positive: the actual node/bottube_feed_routes.py change is small and directionally useful. Wrapping int(raw_limit) in except (ValueError, TypeError) prevents limit=abc from turning into an unhandled route exception, while preserving the existing default, clamp-to-maximum, and minimum-floor behavior.

  3. Positive: the new parser tests in node/tests/test_bottube_feed_routes.py cover the important limit cases directly: missing/empty limit, valid numeric limit, large clamp, zero/negative floor, and non-numeric fallback. I also ran the focused suite locally with the existing repo venv: /Users/chen/Documents/Codex/2026-05-26/github-pr/Rustchain-review/.venv/bin/python -m pytest node/tests/test_bottube_feed_routes.py -q -> 24 passed.

Suggested fix: restore the p2p.py dict entry and, ideally, rebase/drop the unrelated stacked commits so this PR only carries the T9 feed-route change. After that, the focused feed-route portion looks good to me.

I received RTC compensation for this review.

@shadow88sky shadow88sky mentioned this pull request May 26, 2026
Open
jaxint
jaxint reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for contributing to RustChain! 🦀

@jaxint jaxint mentioned this pull request May 26, 2026
Open
jaxint
jaxint reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for contributing to RustChain! 🦀

@jaxint jaxint mentioned this pull request May 26, 2026
Open
jaxint
jaxint reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for contributing to RustChain! 🦀

@jaxint jaxint mentioned this pull request May 26, 2026
Open
jaxint
jaxint reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for contributing to RustChain! 🦀

@jaxint jaxint mentioned this pull request May 26, 2026
Open
jaxint
jaxint reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for contributing to RustChain! 🦀

@jaxint jaxint mentioned this pull request May 26, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jaxint jaxint jaxint approved these changes

@shadow88sky shadow88sky shadow88sky requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api API endpoint related BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) documentation Improvements or additions to documentation node Node server related size/XL PR: 500+ lines tests Test suite changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@waefrebeorn @shadow88sky @jaxint