F23 Relic Bare Except#6331

Closed

waefrebeorn wants to merge 52 commits into

Scottcjn:mainfrom

waefrebeorn:fix/f23-relic-bare-except

waefrebeorn commented May 25, 2026

RTC Wallet: RTC17c0d21f04f6f65c1a85c0aeb5d4a305d57531096

waefrebeorn added 30 commits

May 25, 2026 01:16


          update battleship: add A18 + exhausted cells + PR tracking

05b4762


          battleship: add A19 (beacon_api field lengths -> PR Scottcjn#6262)


          battleship: add A20 (bridge address lengths -> PR Scottcjn#6263)

0e12446


          battleship: add A21 (airdrop field lengths -> PR Scottcjn#6264)

4b9683c


          battleship: add A22 (lock_ledger -> PR Scottcjn#6265)

f9ce59b


          battleship: add A23 (sync endpoints -> PR Scottcjn#6266)

c02eefa


          fix: cap unbounded string fields in bridge/bridge_api.py (A24)

b9388aa

Adds max_length parameter to _clean_string_field and caps all user input
fields in POST route handlers:

- /lock: sender_wallet(128), target_wallet(128), tx_hash(128), receipt_signature(256)
- /confirm: proof_ref(256), notes(1024)
- /release: release_tx(128), notes(1024)

Prevents storage of arbitrarily large strings in bridge_ledger DB.


          docs: add A24 to BATTLESHIP_PROGRESS

2832c96


          fix: cap wallet address in faucet.py (A25)

1c9b2dc


          docs: add A25 to BATTLESHIP_PROGRESS

e8300bd


          fix: cap miner_id in sophia_api.py (A26)

914245d


          docs: add A26 to BATTLESHIP_PROGRESS

b78ae6a


          fix: cap unbounded path params in explorer (A27/A29) and p2p (A28)

7af5c79


          docs: add A27-A29 to BATTLESHIP_PROGRESS

36d0d6a


          fix: cap string fields in testnet faucet and rent-a-relic (A30-A31)

70d458d


          docs: add A30-A31 to BATTLESHIP_PROGRESS

d6060c8


          fix: cap address/search in explorer-api (A32-A33)

48ff7ce


          docs: add A32-A33 to BATTLESHIP_PROGRESS

ace2a62


          fix: cap unbounded path params in 4 route files (A34-A37)

29e80ee


          docs: add A34-A37 to BATTLESHIP_PROGRESS

fdefdd7


          fix: cap unbounded fields in contributor_registry and hall_of_rust (A…

3702de5

…38-A39)


          docs: add A38-A39 to BATTLESHIP_PROGRESS

f182f1e


          fix: cap string fields in machine_passport_api.py (A40)

c8e41f4


          docs: add A40 to BATTLESHIP_PROGRESS

f5c9173


          fix: cap agent_name in bottube_mood_engine.py (A41)

b2a729d


          docs: add A41 to BATTLESHIP_PROGRESS

45597b8


          docs: expand grid to 400 cells, vault 56 accomplished, add Row S stub…

c6180af

…s + Row M error handling + Row T test gaps + Row E infrastructure


          docs: S1 completed (PR Scottcjn#6286), next S2

c44b7ea


          docs: S3 done (PR Scottcjn#6287), S2 removed (false positive-tests only)

1bf19c1


          docs: mark S4-S7, S13, S17-S20 done on battleship board

f277aa2

jaxint approved these changes

View reviewed changes

Contributor

jaxint left a comment

Great contribution! LGTM.

jaxint mentioned this pull request

PR Review Claim - 2026-05-25 19:38 UTC Scottcjn/rustchain-bounties#12341

Open

jaxint reviewed

View reviewed changes

Contributor

jaxint left a comment

Thanks for contributing to RustChain! 🦀

Review Summary:

Code structure looks good
Changes align with project goals
No obvious issues detected

Keep up the great work! 🚀

Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG

jaxint reviewed

View reviewed changes

Contributor

jaxint left a comment

Thanks for contributing! 🦀

Code looks good. Keep it up! 🚀

Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG

jaxint mentioned this pull request

[PR Review] Bounty Claim - 2026-05-26 04:48 UTC Scottcjn/rustchain-bounties#12346

Open

jaxint approved these changes

View reviewed changes

Contributor

jaxint left a comment

LGTM! Great work on this PR. 🚀

jaxint mentioned this pull request

PR Review Claim - 10 PRs - 2026-05-25 21:56 UTC Scottcjn/rustchain-bounties#12348

Open

jaxint reviewed

View reviewed changes

Contributor

jaxint left a comment

Great work! Thanks for contributing to RustChain! 🦀

jaxint mentioned this pull request

PR Review Claim - 29 PRs - 2026-05-25 23:05 UTC Scottcjn/rustchain-bounties#12350

Open

jaxint reviewed

View reviewed changes

Contributor

jaxint left a comment

Great work! Thanks for contributing to RustChain! 🦀

jaxint mentioned this pull request

PR Review Claim - 30 PRs - 2026-05-26 00:08 UTC Scottcjn/rustchain-bounties#12352

Open

jaxint reviewed

View reviewed changes

Contributor

jaxint left a comment

Great work on this PR! The code looks clean and well-structured.

Review powered by RustChain Bounty Program

Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG

jaxint mentioned this pull request

RTC Bounty Claim - 2026-05-26 04:00 UTC Scottcjn/rustchain-bounties#12355

Open

jaxint reviewed

View reviewed changes

Contributor

jaxint left a comment

Great work! Thanks for contributing to RustChain! 🦀

jaxint mentioned this pull request

PR Review Claim - 30 PRs Scottcjn/rustchain-bounties#12357

Open

jaxint reviewed

View reviewed changes

Contributor

jaxint left a comment

Great work! Thanks for contributing to RustChain! 🦀

jaxint mentioned this pull request

PR Review Claim - 30 PRs Scottcjn/rustchain-bounties#12368

Open

jaxint reviewed

View reviewed changes

Contributor

jaxint left a comment

Code review completed. Thanks for contributing to RustChain! 🚀

jaxint reviewed

View reviewed changes

Contributor

jaxint left a comment

Great work! Thanks for contributing to RustChain! 🦀

jaxint mentioned this pull request

PR Review Claim - 29 PRs Scottcjn/rustchain-bounties#12376

Open

jaxint reviewed

View reviewed changes

Contributor

jaxint left a comment

Great work! Thanks for contributing to RustChain! 🦀

jaxint mentioned this pull request

PR Review Claim - 29 PRs Scottcjn/rustchain-bounties#12378

Open

jaxint reviewed

View reviewed changes

Contributor

jaxint left a comment

Great work! Thanks for contributing to RustChain! 🦀

jaxint mentioned this pull request

PR Review Claim - 29 PRs Scottcjn/rustchain-bounties#12387

Open

shadow88sky suggested changes

View reviewed changes

shadow88sky left a comment

Thanks for the F23 rent-a-relic cleanup. The focused target change in tools/rent_a_relic/mcp_integration.py is directionally good: the broad except Exception: around response-body parsing is narrowed to (json.JSONDecodeError, AttributeError, TypeError), and the remaining pass is now an intentional fallback to str(exc) when the HTTP response body is not usable JSON.

Validation I ran:

.venv/bin/python -m py_compile tools/rent_a_relic/mcp_integration.py -> passes
gh pr checks 6331 -R Scottcjn/Rustchain -> all checks currently passing

I still need to request changes because the submitted branch is much broader than the F23 title/scope and has whitespace failures:

The PR title/scope is F23 Relic Bare Except, but the branch changes 22 files, including README/bounty-grid updates, unrelated API field-length changes, Telegram bot logging changes, and node/tests/test_claims_settlement.py.
git diff --check $(git rev-list --max-parents=0 HEAD)..HEAD fails with trailing whitespace in:
- BATTLESHIP_PROGRESS.md:3-6
- faucet.py:393
- node/machine_passport_api.py:294
- node/machine_passport_api.py:367

The actual F23 edit looks small and reasonable; this should be narrowed/rebased to the rent-a-relic MCP integration change and the whitespace issues removed.

shadow88sky mentioned this pull request

[ONBOARD: 2 RTC] Star + Review an Open PR Scottcjn/rustchain-bounties#2782

Open

Author

waefrebeorn commented May 26, 2026

Superseded by #6362 (clean branch from origin/main, single commit, no unrelated files).

waefrebeorn mentioned this pull request

fix: narrow bare except to specific json exceptions in mcp_integration (F23) #6362

Open

Author

waefrebeorn commented May 26, 2026

Superseded by clean replacement PR #6362 (same fix, no unrelated files, clean branch from origin/main).

waefrebeorn closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api BCOS-L1 documentation node size/XL tests