Skip to content

ci: refactor ci workflow#6626

Merged
niheaven merged 3 commits intoScoopInstaller:developfrom
chawyehsu:work/refactor-ci
Apr 3, 2026
Merged

ci: refactor ci workflow#6626
niheaven merged 3 commits intoScoopInstaller:developfrom
chawyehsu:work/refactor-ci

Conversation

@chawyehsu
Copy link
Copy Markdown
Member

@chawyehsu chawyehsu commented Mar 27, 2026

Description

  • Drop appveyor support
  • Refactor CI workflow: use matrix and pin actions version

Motivation and Context

xref: ScoopInstaller/Install#127

How Has This Been Tested?

CI

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

Summary by CodeRabbit

  • Chores
    • Consolidated CI workflow to streamline testing across PowerShell environments
    • Pinned CI action versions for more consistent runs
    • Expanded test dependency caching for faster builds
    • Removed legacy CI configuration
  • Documentation
    • Added a "Continuous Integration" entry to the changelog reflecting these updates

Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
@chawyehsu chawyehsu self-assigned this Mar 27, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0f128a8f-132f-49d4-a915-8e14e8497890

📥 Commits

Reviewing files that changed from the base of the PR and between 5d743df and 088f7f7.

📒 Files selected for processing (1)
  • CHANGELOG.md
✅ Files skipped from review due to trivial changes (1)
  • CHANGELOG.md

Walkthrough

Consolidated GitHub Actions CI: renamed workflow and merged two shell-specific jobs into one matrixed test job with pinned actions and expanded caching. Removed the appveyor.yml file. Added an Unreleased changelog note about CI changes.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/ci.yml
Renamed workflow to "CI"; merged test_powershell and test_pwsh into a matrixed test job using powershell and pwsh; pinned actions/checkout to v6.0.1 and potatoqualitee/psmodulecache to v6.2.1; expanded cache to include PSScriptAnalyzer, BuildHelpers, and Pester; unified test step to ./test/bin/test.ps1.
Legacy CI Removal
appveyor.yml
Removed entire AppVeyor configuration (build matrix, environment settings, cache mappings, and PS/PowerShell execution flow).
Changelog
CHANGELOG.md
Added Unreleased "Continuous Integration" entry noting removal of AppVeyor and GitHub Actions workflow refactor.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through YAML, neat and spry,
Merging jobs beneath the sky,
Old AppVeyor waved goodbye,
Matrix testing leaps on by,
CI carrots gleam—let's fly! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci: refactor ci workflow' accurately describes the main changes: dropping AppVeyor and refactoring the GitHub Actions CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/ci.yml:
- Line 1: The workflow file's first line ("name: CI") uses wrong CRLF line
endings; convert this YAML file to use LF-only line endings to satisfy yamllint.
Fix it by normalizing the file to LF (e.g., run dos2unix on the file or change
your editor to save with LF), commit the normalized file, and optionally add a
.gitattributes entry (e.g., "*.yml text eol=lf") or set git config
core.autocrlf=false to prevent reintroducing CRLF in future commits.
- Around line 11-16: The workflow currently sets matrix shell selection into the
defaults.run.shell which cannot accept expressions; update the CI job by
removing the expression from defaults.run.shell and instead set shell: ${{
matrix.shell }} directly on the specific run step (the run step at Line 29
referenced in the comment) so the job uses the matrix value at execution time;
remove or clear defaults.run.shell and add shell: ${{ matrix.shell }} under the
run step that executes commands to fix the parsing error.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 508f9414-3c99-4d1b-9a02-7fb54463d15a

📥 Commits

Reviewing files that changed from the base of the PR and between 0d0334c and 5d743df.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • appveyor.yml
💤 Files with no reviewable changes (1)
  • appveyor.yml

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
@chawyehsu chawyehsu changed the title ci: refactor ci testing ci: refactor ci workflow Mar 27, 2026
@niheaven niheaven merged commit 3cc2fe7 into ScoopInstaller:develop Apr 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants