ci: refactor ci workflow#6626
Conversation
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughConsolidated GitHub Actions CI: renamed workflow and merged two shell-specific jobs into one matrixed Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci.yml:
- Line 1: The workflow file's first line ("name: CI") uses wrong CRLF line
endings; convert this YAML file to use LF-only line endings to satisfy yamllint.
Fix it by normalizing the file to LF (e.g., run dos2unix on the file or change
your editor to save with LF), commit the normalized file, and optionally add a
.gitattributes entry (e.g., "*.yml text eol=lf") or set git config
core.autocrlf=false to prevent reintroducing CRLF in future commits.
- Around line 11-16: The workflow currently sets matrix shell selection into the
defaults.run.shell which cannot accept expressions; update the CI job by
removing the expression from defaults.run.shell and instead set shell: ${{
matrix.shell }} directly on the specific run step (the run step at Line 29
referenced in the comment) so the job uses the matrix value at execution time;
remove or clear defaults.run.shell and add shell: ${{ matrix.shell }} under the
run step that executes commands to fix the parsing error.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 508f9414-3c99-4d1b-9a02-7fb54463d15a
📒 Files selected for processing (2)
.github/workflows/ci.ymlappveyor.yml
💤 Files with no reviewable changes (1)
- appveyor.yml
Description
Motivation and Context
xref: ScoopInstaller/Install#127
How Has This Been Tested?
CI
Checklist:
developbranch.Summary by CodeRabbit