Speed up PP field iteration#7089
Merged
Merged
Conversation
trexfeathers
added
Type: Performance
benchmark_this
Contributor
⏱️ Performance Benchmark Report: f7e0401Performance shiftsFull benchmark resultsGenerated by GHA run |
Contributor
Author
|
Benchmarks drift by 1-2% between each run, which is why there is a concept of 'significant' changes. But it's worth noting that all the PP benchmarks drifted in the 'correct' direction, so there has probably been a small impact, in a good way. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7089 +/- ##
=======================================
Coverage 90.12% 90.12%
=======================================
Files 91 91
Lines 24951 24953 +2
Branches 4683 4683
=======================================
+ Hits 22488 22490 +2
Misses 1684 1684
Partials 779 779 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ukmo-ccbunney
approved these changes
May 15, 2026
Contributor
ukmo-ccbunney
left a comment
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
Nicely done! 👌🏼
Plus we've learnt something about Python and NumPy file pointer interactions! 🤓
Is it worth updating this PR's summary to include why the change was made for future reference?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
From a week of real world observations and a 1 hour conversation with Copilot.
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: