Update RTD server #777
Conversation
There was a problem hiding this comment.
Templating
This PR includes changes that may be worth sharing via templating. For each file listed below, please either:
- Action the suggestion via a pull request editing/adding the relevant file in the SciTools/.github
templates/directory. 1 - Raise an issue against the SciTools/.github repo for the above action if you really don't have 10mins spare right now. Include an assignee, to avoid it being forgotten.
- Dismiss the suggestion if the changes are not suitable for templating.
You will need to dismiss this review before this PR can be merged. Recommend the reviewer does this as their final action before merging, as this text will continually update as commits come in.
Template candidates
The following changed files are not currently templated, but their parent directories suggest they may be good candidates for a new template to be created:
Footnotes
-
Include this text in the PR body to avoid any notifications about applying the template changes back to the source repo!
@scitools-templating: please no update notification on: iris-grib↩
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
=======================================
Coverage 90.05% 90.05%
=======================================
Files 10 10
Lines 2564 2564
Branches 420 420
=======================================
Hits 2309 2309
Misses 156 156
Partials 99 99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Modded to see if v24 will work, as v26 apparently does not. More likely, it is time to remove reference to mamba ??? |
5691864 to
10084b0
Compare
Too specific to each project for a template, I think
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
Looks fine, apart from failing test (seems like a timeout?)
Just one comment.
It isn't a test timeout. It's a url that is not responding. What was your other issue? I think you didn't post the comment |
Actually I'm probably wrong about that. |
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
Sorry - didn't post the comment!
(Yes - I meant that the URL access (repo-review) is timing out on the tests, not the tests themselves).
| os: ubuntu-20.04 | ||
| os: ubuntu-24.04 | ||
| tools: | ||
| python: mambaforge-4.10 |
There was a problem hiding this comment.
According to the RTD docs,, mambaforge-4.10 is deprecated too...
Since RTD is now warning that ubunutu-20 is deprecated.
To highest current ubuntu version = 26.04
Not using 'latest', for stability reasons.