Open
Conversation
Moved MUMPS solver structure declaration below stencils for proper initialization.
Reordered MUMPS solver structure declaration to follow stencils.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
- Coverage 95.18% 94.94% -0.25%
==========================================
Files 94 93 -1
Lines 9345 9236 -109
==========================================
- Hits 8895 8769 -126
- Misses 450 467 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EmilyBourne
reviewed
Feb 19, 2026
EmilyBourne
reviewed
Feb 23, 2026
src/DirectSolver/DirectSolver-COO-MUMPS-Give/directSolverGive.cpp
Outdated
Show resolved
Hide resolved
src/ExtrapolatedSmoother/ExtrapolatedSmootherGive/extrapolatedSmootherGive.cpp
Outdated
Show resolved
Hide resolved
EmilyBourne
reviewed
Mar 9, 2026
| target_link_libraries(GMGPolarLib PUBLIC OpenMP::OpenMP_CXX) | ||
| endif() | ||
| find_package(Kokkos 4.4.1...<5 QUIET REQUIRED) | ||
| find_package(Kokkos 4.4.1...<5.1 QUIET REQUIRED) |
Collaborator
There was a problem hiding this comment.
By the way, (unrelated to this Pr), do you know why the find_package calls (OpenMP, kokkos, etc) are found in src/CMakeLists.txt? It is usual to group all the package dependencies together at the top level CMakeLists.txt
Collaborator
Author
There was a problem hiding this comment.
Can be moved to the outer CMakeLists.txt if you like to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):