Merged
Conversation
benjaminach
changed the title
EtienneM
approved these changes
May 5, 2026
Member
EtienneM
left a comment
EtienneM
left a comment
There was a problem hiding this comment.
Just a suggestion, otherwise LGTM
Frzk
approved these changes
May 5, 2026
| | --------------------- | --------------- | ---------------------------- | | ||
| | `alert_added` | Alert Added | An alert has been configured | | ||
| | `alert_deleted` | Alert Deleted | An alert has been deleted | | ||
| | `app_alert_triggered` | Alert triggered | An alert was triggered | |
Contributor
There was a problem hiding this comment.
An alert was triggerd
question: Shouldn't we also use "An alert has been triggered"?
Contributor
Author
There was a problem hiding this comment.
Yes, I saw that too, and that's the current wording in the admin, so I have chosen to leave it that way since we should rework the notifier description as a whole.
EtienneM
force-pushed
the
feat/notifiers-events-discoverability
branch
from
c78f01b to
16ea8f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ideally, this PR should be updated after https://github.com/Scalingo/api/pull/3293 is merged.