feat: indicate active editing in toolbar#444
Open
RobertMueller2 wants to merge 1 commit intoSatty-org:mainfrom
Open
feat: indicate active editing in toolbar#444RobertMueller2 wants to merge 1 commit intoSatty-org:mainfrom
RobertMueller2 wants to merge 1 commit intoSatty-org:mainfrom
Conversation
RobertMueller2
force-pushed
the
active_tool_style
branch
2 times, most recently
from
3353de8 to
fa519a2
Compare
RobertMueller2
force-pushed
the
active_tool_style
branch
from
fa519a2 to
bf31904
Compare
RobertMueller2
force-pushed
the
active_tool_style
branch
2 times, most recently
from
b02fb51 to
3467410
Compare
Member
Author
|
I think, when #357 is merged, I'd like to utilise the new crop dimension area for tool output info. And if the active tool isn't currently editing, we can show image dimensions or crop dimensions (if a crop is present). Might do that here or open a new PR, not sure yet. Probably a new PR. |
RobertMueller2
force-pushed
the
active_tool_style
branch
from
3467410 to
9eb69e6
Compare
This adds a highlight (using adwaita @accent_color) for the button for a tool that is actively editing. This works for: - arrow - blur - crop - ellipse - highlight - line - rectangle The idea is that it's better visible when esc/enter, which normally trigger actions, are masked by a tool.
RobertMueller2
force-pushed
the
active_tool_style
branch
from
9eb69e6 to
f3e65f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a highlight (using adwaita @accent_color) for the button for a tool that is actively editing. This works for:
The idea is that it's better visible when esc/enter, which normally trigger actions, are masked by a tool.
editing
not editing
